[GitHub] jvnn opened a new issue #1623: Invalid error handling in ps_create_main_conf

[GitBox <gi...@apache.org>]

jvnn opened a new issue #1623: Invalid error handling in ps_create_main_conf
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1623
 
 
   Hi, I happened to notice a little bug while browsing through the code. The `create_main_conf` callback from Nginx expects a NULL pointer as an error return value, but pagespeed returns -1 (NGX_CONF_ERROR) on error.
   
   Compare the error handling code in [ps_create_main_conf](https://github.com/apache/incubator-pagespeed-ngx/blob/v1.13.35.2-stable/src/ngx_pagespeed.cc#L1028) to the call in [ngx_http.c](https://github.com/nginx/nginx/blob/master/src/http/ngx_http.c#L196).
   
   This would only happen if the pool allocation of the main conf structure fails (probably very rare), but would lead to -1 used as a conf pointer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services