You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2017/06/02 17:01:10 UTC
[native-toolchain-CR] IMPALA-5357: Patch boost time duration bug
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7056
Change subject: IMPALA-5357: Patch boost time_duration bug
......................................................................
IMPALA-5357: Patch boost time_duration bug
Upstream boost issue:
https://svn.boost.org/trac/boost/ticket/4543
Backported from upstream date_time:
https://github.com/boostorg/date_time/pull/35/commits/818dea52f3f0c8b4f5172df13c5fa4f57340625f
This fixes an issue in which time_duration was using an
int32 internally, limiting its year range from 1902-2038. With this
fix, time_duration supports years from 1677-2262. Note this
is still not as wide as Impala's supported timestamp range
(which is 1600-9999), but still enables Impala to use boost
in most common cases to address IMPALA-5357.
Change-Id: Idee1b84bd7d3515c98c482e691119d04dc71f929
---
M buildall.sh
A source/boost/boost-1.57.0-patches/0002-IMPALA-5357.patch
2 files changed, 72 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/56/7056/1
--
To view, visit http://gerrit.cloudera.org:8080/7056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idee1b84bd7d3515c98c482e691119d04dc71f929
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
[native-toolchain-CR] IMPALA-5357: Patch boost time duration bug
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5357: Patch boost time_duration bug
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7056/1/source/boost/boost-1.57.0-patches/0002-IMPALA-5357.patch
File source/boost/boost-1.57.0-patches/0002-IMPALA-5357.patch:
Line 65: + typename v_type = std::time_t >
> Can this patch be simplified to just the two changed lines in this file: in
Possibly, though I think arguably it makes sense to keep the change to from_time_t above as the removal of the static_cast<long> improves portability, even if we plan on always using systems where time_t == long. Given that this patch also went in upstream, I think it's reasonable to keep it together. If you feel strongly I can probably remove the changes to the first file.
--
To view, visit http://gerrit.cloudera.org:8080/7056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idee1b84bd7d3515c98c482e691119d04dc71f929
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-5357: Patch boost time duration bug
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5357: Patch boost time_duration bug
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idee1b84bd7d3515c98c482e691119d04dc71f929
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-5357: Patch boost time duration bug
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5357: Patch boost time_duration bug
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idee1b84bd7d3515c98c482e691119d04dc71f929
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-5357: Patch boost time duration bug
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has submitted this change and it was merged.
Change subject: IMPALA-5357: Patch boost time_duration bug
......................................................................
IMPALA-5357: Patch boost time_duration bug
Upstream boost issue:
https://svn.boost.org/trac/boost/ticket/4543
Backported from upstream date_time:
https://github.com/boostorg/date_time/pull/35/commits/818dea52f3f0c8b4f5172df13c5fa4f57340625f
This fixes an issue in which time_duration was using an
int32 internally, limiting its year range from 1902-2038. With this
fix, time_duration supports years from 1677-2262. Note this
is still not as wide as Impala's supported timestamp range
(which is 1600-9999), but still enables Impala to use boost
in most common cases to address IMPALA-5357.
Change-Id: Idee1b84bd7d3515c98c482e691119d04dc71f929
---
M buildall.sh
A source/boost/boost-1.57.0-patches/0002-IMPALA-5357.patch
2 files changed, 72 insertions(+), 3 deletions(-)
Approvals:
Jim Apple: Looks good to me, but someone else must approve
Matthew Jacobs: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idee1b84bd7d3515c98c482e691119d04dc71f929
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] IMPALA-5357: Patch boost time duration bug
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5357: Patch boost time_duration bug
......................................................................
Patch Set 1:
> (1 comment)
np, thanks for taking a look
--
To view, visit http://gerrit.cloudera.org:8080/7056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idee1b84bd7d3515c98c482e691119d04dc71f929
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-5357: Patch boost time duration bug
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5357: Patch boost time_duration bug
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idee1b84bd7d3515c98c482e691119d04dc71f929
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-5357: Patch boost time duration bug
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5357: Patch boost time_duration bug
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7056/1/source/boost/boost-1.57.0-patches/0002-IMPALA-5357.patch
File source/boost/boost-1.57.0-patches/0002-IMPALA-5357.patch:
Line 65: + typename v_type = std::time_t >
Can this patch be simplified to just the two changed lines in this file: including ctime and using std::time_t?
--
To view, visit http://gerrit.cloudera.org:8080/7056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idee1b84bd7d3515c98c482e691119d04dc71f929
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-5357: Patch boost time duration bug
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5357: Patch boost time_duration bug
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7056/1/source/boost/boost-1.57.0-patches/0002-IMPALA-5357.patch
File source/boost/boost-1.57.0-patches/0002-IMPALA-5357.patch:
Line 65: + typename v_type = std::time_t >
> Possibly, though I think arguably it makes sense to keep the change to from
SG. I'm not familiar enough with the build numbers to +2, but I'm convinced of the validity of the patch.
--
To view, visit http://gerrit.cloudera.org:8080/7056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idee1b84bd7d3515c98c482e691119d04dc71f929
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-5357: Patch boost time duration bug
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5357: Patch boost time_duration bug
......................................................................
Patch Set 1:
Passed an exhaustive run
--
To view, visit http://gerrit.cloudera.org:8080/7056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idee1b84bd7d3515c98c482e691119d04dc71f929
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No