You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Goutam Tadi <go...@gmail.com> on 2016/03/01 18:20:22 UTC
Re: Review Request 44211: Currently PXF's service check failure does
not tell too much and it is hard to debug.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44211/
-----------------------------------------------------------
(Updated March 1, 2016, 5:20 p.m.)
Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, Matt, and Newton Alex.
Bugs: AMBARI-15249
https://issues.apache.org/jira/browse/AMBARI-15249
Repository: ambari
Description
-------
pxf service check failure does not tell why it fails. Include debug messages for ease.
Diffs
-----
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py 6f60661
Diff: https://reviews.apache.org/r/44211/diff/
Testing
-------
Yes, tested.
Thanks,
Goutam Tadi
Re: Review Request 44211: Currently PXF's service check failure does
not tell too much and it is hard to debug.
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44211/#review122162
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py (line 62)
<https://reviews.apache.org/r/44211/#comment184058>
Do you want to start with 0, and increment it before each test is executed?
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py (line 98)
<https://reviews.apache.org/r/44211/#comment184059>
Those detailed messages count for troubleshooting. Good work!
- jun aoki
On March 4, 2016, 4:41 a.m., Goutam Tadi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44211/
> -----------------------------------------------------------
>
> (Updated March 4, 2016, 4:41 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, Matt, and Newton Alex.
>
>
> Bugs: AMBARI-15249
> https://issues.apache.org/jira/browse/AMBARI-15249
>
>
> Repository: ambari
>
>
> Description
> -------
>
> pxf service check failure does not tell why it fails. Include debug messages for ease.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py 6f60661
>
> Diff: https://reviews.apache.org/r/44211/diff/
>
>
> Testing
> -------
>
> Yes, tested.
>
>
> Thanks,
>
> Goutam Tadi
>
>
Re: Review Request 44211: Currently PXF's service check failure does
not tell too much and it is hard to debug.
Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44211/
-----------------------------------------------------------
(Updated March 6, 2016, 12:26 a.m.)
Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, Matt, and Newton Alex.
Changes
-------
Branch-2.2 patch
Bugs: AMBARI-15249
https://issues.apache.org/jira/browse/AMBARI-15249
Repository: ambari
Description
-------
pxf service check failure does not tell why it fails. Include debug messages for ease.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py 6f60661
Diff: https://reviews.apache.org/r/44211/diff/
Testing
-------
Yes, tested.
Thanks,
Goutam Tadi
Re: Review Request 44211: Currently PXF's service check failure does
not tell too much and it is hard to debug.
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44211/#review122212
-----------------------------------------------------------
Ship it!
Ship It!
- Matt
On March 5, 2016, 8:29 a.m., Goutam Tadi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44211/
> -----------------------------------------------------------
>
> (Updated March 5, 2016, 8:29 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, Matt, and Newton Alex.
>
>
> Bugs: AMBARI-15249
> https://issues.apache.org/jira/browse/AMBARI-15249
>
>
> Repository: ambari
>
>
> Description
> -------
>
> pxf service check failure does not tell why it fails. Include debug messages for ease.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py 6f60661
>
> Diff: https://reviews.apache.org/r/44211/diff/
>
>
> Testing
> -------
>
> Yes, tested.
>
>
> Thanks,
>
> Goutam Tadi
>
>
Re: Review Request 44211: Currently PXF's service check failure does
not tell too much and it is hard to debug.
Posted by Lav Jain <lj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44211/#review122211
-----------------------------------------------------------
Ship it!
Ship It!
- Lav Jain
On March 5, 2016, 4:29 p.m., Goutam Tadi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44211/
> -----------------------------------------------------------
>
> (Updated March 5, 2016, 4:29 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, Matt, and Newton Alex.
>
>
> Bugs: AMBARI-15249
> https://issues.apache.org/jira/browse/AMBARI-15249
>
>
> Repository: ambari
>
>
> Description
> -------
>
> pxf service check failure does not tell why it fails. Include debug messages for ease.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py 6f60661
>
> Diff: https://reviews.apache.org/r/44211/diff/
>
>
> Testing
> -------
>
> Yes, tested.
>
>
> Thanks,
>
> Goutam Tadi
>
>
Re: Review Request 44211: Currently PXF's service check failure does
not tell too much and it is hard to debug.
Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44211/
-----------------------------------------------------------
(Updated March 5, 2016, 4:29 p.m.)
Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, Matt, and Newton Alex.
Bugs: AMBARI-15249
https://issues.apache.org/jira/browse/AMBARI-15249
Repository: ambari
Description
-------
pxf service check failure does not tell why it fails. Include debug messages for ease.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py 6f60661
Diff: https://reviews.apache.org/r/44211/diff/
Testing
-------
Yes, tested.
Thanks,
Goutam Tadi
Re: Review Request 44211: Currently PXF's service check failure does
not tell too much and it is hard to debug.
Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44211/
-----------------------------------------------------------
(Updated March 4, 2016, 4:41 a.m.)
Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, Lav Jain, Matt, and Newton Alex.
Bugs: AMBARI-15249
https://issues.apache.org/jira/browse/AMBARI-15249
Repository: ambari
Description
-------
pxf service check failure does not tell why it fails. Include debug messages for ease.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py 6f60661
Diff: https://reviews.apache.org/r/44211/diff/
Testing
-------
Yes, tested.
Thanks,
Goutam Tadi