[GitHub] [solr] janhoy commented on a diff in pull request #1673: MINOR: Document change to mention hadoop/Kerberos Plugins moved to package org.apache.solr.security.hadoop

["janhoy (via GitHub)" <gi...@apache.org>]

janhoy commented on code in PR #1673:
URL: https://github.com/apache/solr/pull/1673#discussion_r1211573242


##########
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc:
##########
@@ -175,7 +175,7 @@ Administrators that need Solr exposed more broadly can change the `SOLR_JETTY_HO
 If you rely upon the previous behavior, then you can change the `clientPortAddress` in `solr/server/solr/zoo.cfg`
 * Jetty low level request-logging in NCSA format is now enabled by default, with a retention of 3 days worth of logs.
 This may require some more disk space for logs than was the case in version 8.x. See xref:deployment-guide:configuring-logging.adoc[Configuring Logging] for how to change this.
-* Hadoop authentication support has been moved to the new `hadoop-auth` module. Existing Solr configurations do not need any Hadoop authentication related changes, however the module needs to be installed - see the section xref:deployment-guide:hadoop-authentication-plugin.adoc[].
+* Hadoop authentication support has been moved to the new `hadoop-auth` module. Users need to add the module hadoop-auth to classpath. The plugins has also changed package name to org.apache.solr.security.hadoop, but can still be loaded as shortform class="solr.HadoopAuthPlugin" or class="solr.ConfigurableInternodeAuthHadoopPlugin" or class="solr.KerberosPlugin"  - see the section xref:deployment-guide:hadoop-authentication-plugin.adoc[].

Review Comment:
   Code formatting:
   ```suggestion
   * Hadoop authentication support has been moved to the new `hadoop-auth` module. Users need to add the module `hadoop-auth` to classpath. The plugins has also changed package name to `org.apache.solr.security.hadoop`, but can still be loaded as shortform `class="solr.HadoopAuthPlugin"`, `class="solr.ConfigurableInternodeAuthHadoopPlugin"` or `class="solr.KerberosPlugin"`  - see the section xref:deployment-guide:hadoop-authentication-plugin.adoc[].
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org