You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/02 01:17:57 UTC
[GitHub] [iotdb] SteveYurongSu commented on a diff in pull request #5696: [IOTDB-2981] Modify antlr, IoTDBSqlVisitor and ASTVisitor for new syntax convention
SteveYurongSu commented on code in PR #5696:
URL: https://github.com/apache/iotdb/pull/5696#discussion_r862550547
##########
antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IoTDBSqlParser.g4:
##########
@@ -950,13 +961,14 @@ attributePair
: key=attributeKey (OPERATOR_SEQ | OPERATOR_DEQ) value=attributeValue
;
-// attribute is treated as string in html
attributeKey
- : STRING_LITERAL
+ :identifier
+ |STRING_LITERAL
Review Comment:
```suggestion
: identifier
| constant
```
##########
antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IoTDBSqlParser.g4:
##########
@@ -950,13 +961,14 @@ attributePair
: key=attributeKey (OPERATOR_SEQ | OPERATOR_DEQ) value=attributeValue
;
-// attribute is treated as string in html
attributeKey
- : STRING_LITERAL
+ :identifier
+ |STRING_LITERAL
;
attributeValue
- : STRING_LITERAL
+ :identifier
+ |constant
Review Comment:
```suggestion
: identifier
| constant
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org