You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/04/15 10:39:44 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #2434:
fix NPE when grant resource or save process definition
codecov-io commented on issue #2434: fix NPE when grant resource or save process definition
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2434#issuecomment-613961664
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2434?src=pr&el=h1) Report
> Merging [#2434](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2434?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/f21837076e0647103fc901e604013d0e21139460&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `60.00%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2434?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2434 +/- ##
============================================
- Coverage 33.47% 33.44% -0.03%
+ Complexity 2307 2306 -1
============================================
Files 423 423
Lines 19868 19870 +2
Branches 2373 2375 +2
============================================
- Hits 6650 6646 -4
- Misses 12624 12632 +8
+ Partials 594 592 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2434?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2434/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `71.23% <0.00%> (-0.46%)` | `82.00 <0.00> (ø)` | |
| [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2434/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `71.17% <85.71%> (-0.21%)` | `66.00 <0.00> (ø)` | |
| [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2434/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `82.60% <0.00%> (-8.70%)` | `6.00% <0.00%> (-1.00%)` | |
| [...ache/dolphinscheduler/dao/entity/ErrorCommand.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2434/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9FcnJvckNvbW1hbmQuamF2YQ==) | `33.33% <0.00%> (ø)` | `21.00% <0.00%> (ø%)` | |
| [...inscheduler/common/task/sqoop/SqoopParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2434/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvU3Fvb3BQYXJhbWV0ZXJzLmphdmE=) | `80.00% <0.00%> (ø)` | `15.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2434?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2434?src=pr&el=footer). Last update [f218370...bf2fde2](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2434?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services