Re: Review Request: Add "rpctoken" url fragment to support flash transport if not available in the url metadata when generating gadget iframe url

[Dan Dumont <dd...@us.ibm.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4703/#review8623
-----------------------------------------------------------


Hey Henry, what's the status of this review?   Committed?  Not needed?

- Dan Dumont


On April 11, 2012, 11:51 p.m., Henry Saputra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4703/
> -----------------------------------------------------------
> 
> (Updated April 11, 2012, 11:51 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Description
> -------
> 
> Add rpctoken in the url fragment to support flash transport in the gadget_holder when generating iframe url. 
> 
> Add small fix to uri.js to simply return empty array if shindig.uri.parseParams() is called with empty string.
> 
> 
> Diffs
> -----
> 
>   trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1325046 
>   trunk/features/src/main/javascript/features/shindig.uri/uri.js 1325046 
>   trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1325046 
> 
> Diff: https://reviews.apache.org/r/4703/diff/
> 
> 
> Testing
> -------
> 
> Update JS unit test.
> 
> 
> Thanks,
> 
> Henry Saputra
> 
>