You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/08 03:47:27 UTC
[GitHub] [shardingsphere] tuichenchuxin opened a new pull request, #16654: Support comment statement for pg/og
tuichenchuxin opened a new pull request, #16654:
URL: https://github.com/apache/shardingsphere/pull/16654
Fixes #16548.
Changes proposed in this pull request:
- support parsing comment.
- add test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #16654: Support comment statement for pg/og
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #16654:
URL: https://github.com/apache/shardingsphere/pull/16654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #16654: Support comment statement for pg/og
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #16654:
URL: https://github.com/apache/shardingsphere/pull/16654#discussion_r845732838
##########
shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-opengauss/src/main/java/org/apache/shardingsphere/sql/parser/opengauss/visitor/statement/impl/OpenGaussDDLStatementSQLVisitor.java:
##########
@@ -743,4 +745,9 @@ public ASTNode visitDropExtension(final DropExtensionContext ctx) {
public ASTNode visitDeclare(final DeclareContext ctx) {
return new OpenGaussDeclareStatement();
}
+
+ @Override
+ public ASTNode visitComment(final OpenGaussStatementParser.CommentContext ctx) {
Review Comment:
Please use static import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin commented on a diff in pull request #16654: Support comment statement for pg/og
Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on code in PR #16654:
URL: https://github.com/apache/shardingsphere/pull/16654#discussion_r845734112
##########
shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-opengauss/src/main/java/org/apache/shardingsphere/sql/parser/opengauss/visitor/statement/impl/OpenGaussDDLStatementSQLVisitor.java:
##########
@@ -743,4 +745,9 @@ public ASTNode visitDropExtension(final DropExtensionContext ctx) {
public ASTNode visitDeclare(final DeclareContext ctx) {
return new OpenGaussDeclareStatement();
}
+
+ @Override
+ public ASTNode visitComment(final OpenGaussStatementParser.CommentContext ctx) {
Review Comment:
Thank you. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org