You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@linkis.apache.org by GitBox <gi...@apache.org> on 2022/03/16 03:38:00 UTC
[GitHub] [incubator-linkis] AbnerHung opened a new pull request #1736: Dev 1.2.0 Add junit5 test code for [linkis-common]
AbnerHung opened a new pull request #1736:
URL: https://github.com/apache/incubator-linkis/pull/1736
### What is the purpose of the change
Add JUNIT test for ErrorCodeUtils & LinkisCommonsErrorCodeSummary
Related issues: #1634 .
### Brief change log
- Add test code for org.apache.linkis.common.errorcode.ErrorCodeUtils;
- Add test code for org.apache.linkis.common.errorcode.LinkisCommonsErrorCodeSummary.
### Verifying this change
- Added some tests under the [linkis-common] module, which pass after excluding conflicting dependencies locally.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- Anything that affects deployment: (don't know)
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] husofskyzy commented on pull request #1736: Dev 1.2.0 Add junit5 test code for [linkis-common]
Posted by GitBox <gi...@apache.org>.
husofskyzy commented on pull request #1736:
URL: https://github.com/apache/incubator-linkis/pull/1736#issuecomment-1069821971
plz put the test code to dev1.1.1 branch and make sure it can get through Packaging process，we would not like there to be try catch in the code,so maybe you can change the code style such as
@Test(expected= IndexOutOfBoundsException.class)
public void empty() {
new ArrayList<Object>().get(0);
}
At 2022-03-16 11:41:53, "めぐみん" ***@***.***> wrote:
@husofskyzy Could u plz review the code and give me some advice so I can improve myself and move on to the rest of the work?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] AbnerHung commented on pull request #1736: Dev 1.2.0 Add junit5 test code for [linkis-common]
Posted by GitBox <gi...@apache.org>.
AbnerHung commented on pull request #1736:
URL: https://github.com/apache/incubator-linkis/pull/1736#issuecomment-1068699374
@husofskyzy Could u plz review the code and give me some advice so I can improve myself and move on to the rest of the work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] AbnerHung commented on pull request #1736: Dev 1.2.0 Add junit5 test code for [linkis-common]
Posted by GitBox <gi...@apache.org>.
AbnerHung commented on pull request #1736:
URL: https://github.com/apache/incubator-linkis/pull/1736#issuecomment-1069826002
Thx! I'll check it again.
------------------ Original ------------------
From: "apache/incubator-linkis" ***@***.***>;
Date: Thu, Mar 17, 2022 09:45 AM
***@***.***>;
***@***.******@***.***>;
Subject: Re: [apache/incubator-linkis] Dev 1.2.0 Add junit5 test code for [linkis-common] (PR #1736)
plz put the test code to dev1.1.1 branch and make sure it can get through Packaging process，we would not like there to be try catch in the code,so maybe you can change the code style such as
@Test(expected= IndexOutOfBoundsException.class)
public void empty() {
new ArrayList<Object>().get(0);
}
At 2022-03-16 11:41:53, "めぐみん" ***@***.***> wrote:
@husofskyzy Could u plz review the code and give me some advice so I can improve myself and move on to the rest of the work?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] AbnerHung closed pull request #1736: Dev 1.2.0 Add junit5 test code for [linkis-common]
Posted by GitBox <gi...@apache.org>.
AbnerHung closed pull request #1736:
URL: https://github.com/apache/incubator-linkis/pull/1736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org