You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2016/01/04 19:02:10 UTC
Review Request 41887: SQOOP-2768 Sqoop2: Remove the notion of
LinksBeans
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41887/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2768
https://issues.apache.org/jira/browse/SQOOP-2768
Repository: sqoop-sqoop2
Description
-------
I've removed the LinksBeans class as suggested on JIRA.
Diffs
-----
common/src/main/java/org/apache/sqoop/json/LinkBean.java 8ce8b2b
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 0df0f9d
common/src/test/java/org/apache/sqoop/json/TestLinksBean.java 0ee29fa
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 9f6ed90
Diff: https://reviews.apache.org/r/41887/diff/
Testing
-------
Unit tests are passing on my box, I did not run integration tests (will be done by precommit hook).
Thanks,
Jarek Cecho
Re: Review Request 41887: SQOOP-2768 Sqoop2: Remove the notion of
LinksBeans
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41887/#review114412
-----------------------------------------------------------
Ship it!
Ship It!
- Dian Fu
On Jan. 4, 2016, 6:54 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41887/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 6:54 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2768
> https://issues.apache.org/jira/browse/SQOOP-2768
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've removed the LinksBeans class as suggested on JIRA.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 2b19dac
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 8ce8b2b
> common/src/main/java/org/apache/sqoop/json/LinksBean.java 87e873d
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 0df0f9d
> common/src/test/java/org/apache/sqoop/json/TestLinksBean.java 0ee29fa
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 9f6ed90
> test/src/test/java/org/apache/sqoop/integration/tools/RepositoryDumpLoadToolTest.java 03d4a9f
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 6958ee1
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 748ef80
>
> Diff: https://reviews.apache.org/r/41887/diff/
>
>
> Testing
> -------
>
> Unit tests are passing on my box, I did not run integration tests (will be done by precommit hook).
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 41887: SQOOP-2768 Sqoop2: Remove the notion of
LinksBeans
Posted by Abraham Fine <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41887/#review112920
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Fine
On Jan. 4, 2016, 6:54 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41887/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 6:54 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2768
> https://issues.apache.org/jira/browse/SQOOP-2768
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've removed the LinksBeans class as suggested on JIRA.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 2b19dac
> common/src/main/java/org/apache/sqoop/json/LinkBean.java 8ce8b2b
> common/src/main/java/org/apache/sqoop/json/LinksBean.java 87e873d
> common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 0df0f9d
> common/src/test/java/org/apache/sqoop/json/TestLinksBean.java 0ee29fa
> server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 9f6ed90
> test/src/test/java/org/apache/sqoop/integration/tools/RepositoryDumpLoadToolTest.java 03d4a9f
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 6958ee1
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 748ef80
>
> Diff: https://reviews.apache.org/r/41887/diff/
>
>
> Testing
> -------
>
> Unit tests are passing on my box, I did not run integration tests (will be done by precommit hook).
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 41887: SQOOP-2768 Sqoop2: Remove the notion of
LinksBeans
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41887/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 6:54 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2768
https://issues.apache.org/jira/browse/SQOOP-2768
Repository: sqoop-sqoop2
Description
-------
I've removed the LinksBeans class as suggested on JIRA.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 2b19dac
common/src/main/java/org/apache/sqoop/json/LinkBean.java 8ce8b2b
common/src/main/java/org/apache/sqoop/json/LinksBean.java 87e873d
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 0df0f9d
common/src/test/java/org/apache/sqoop/json/TestLinksBean.java 0ee29fa
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 9f6ed90
test/src/test/java/org/apache/sqoop/integration/tools/RepositoryDumpLoadToolTest.java 03d4a9f
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 6958ee1
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 748ef80
Diff: https://reviews.apache.org/r/41887/diff/
Testing
-------
Unit tests are passing on my box, I did not run integration tests (will be done by precommit hook).
Thanks,
Jarek Cecho