You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/12/17 08:33:16 UTC
[GitHub] [calcite] jinxing64 commented on a change in pull request #1655:
[CALCITE-3387] Query with GROUP BY and JOIN ... USING wrongly fails with
"Column DEPTNO is ambiguous" error
jinxing64 commented on a change in pull request #1655: [CALCITE-3387] Query with GROUP BY and JOIN ... USING wrongly fails with "Column DEPTNO is ambiguous" error
URL: https://github.com/apache/calcite/pull/1655#discussion_r358644912
##########
File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
##########
@@ -449,7 +449,7 @@ private boolean expandSelectItem(
// Expand the select item: fully-qualify columns, and convert
// parentheses-free functions such as LOCALTIME into explicit function
// calls.
- SqlNode expanded = expand(selectItem, scope);
+ SqlNode expanded = expandSelectExpr(selectItem, scope, select);
Review comment:
Not quite sure, with this change, shall we update the doc of `expandSelectItem ` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services