You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/07/06 03:33:50 UTC

[PR] [SPARK-57950] Support `spark.redaction.regex` and redact sensitive values in operator logs [spark-kubernetes-operator]

dongjoon-hyun opened a new pull request, #746:
URL: https://github.com/apache/spark-kubernetes-operator/pull/746

   ### What changes were proposed in this pull request?
   
   This PR aims to redact sensitive configuration values in operator logs.
   
   - Add a new config option, `spark.redaction.regex`, reusing Apache Spark's redaction key and default pattern (`(?i)secret|password|token|access[.]?key`).
   - Add `Utils.redactSensitiveInfo` which replaces a value with `*********(redacted)` when its key or value matches the pattern.
   - Apply redaction to the configuration logging on startup (`spark.logConf`).
   - Escape pipes in `DocTable` cells and regenerate `docs/config_properties.md`.
   
   ### Why are the changes needed?
   
   When `spark.logConf` is enabled, the operator prints all configuration properties without filtering, exposing sensitive values like `*.password` or `spark.hadoop.fs.s3a.access.key` in plain text.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, sensitive configuration values are now printed as `*********(redacted)`, and the pattern is customizable via `spark.redaction.regex`.
   
   ### How was this patch tested?
   
   Pass the CIs with the newly added test cases.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Fable 5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57950] Support `spark.redaction.regex` and redact sensitive values in operator logs [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #746: [SPARK-57950] Support `spark.redaction.regex` and redact sensitive values in operator logs
URL: https://github.com/apache/spark-kubernetes-operator/pull/746


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57950] Support `spark.redaction.regex` and redact sensitive values in operator logs [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #746:
URL: https://github.com/apache/spark-kubernetes-operator/pull/746#issuecomment-4889092514

   Merged to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57950] Support `spark.redaction.regex` and redact sensitive values in operator logs [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #746:
URL: https://github.com/apache/spark-kubernetes-operator/pull/746#issuecomment-4889088625

   Thank you, @viirya !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org