You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/20 01:56:40 UTC

[GitHub] [iceberg] rdblue commented on a diff in pull request #5672: Python: Fine-tune the API

rdblue commented on code in PR #5672:
URL: https://github.com/apache/iceberg/pull/5672#discussion_r974817649


##########
python/pyiceberg/table/sorting.py:
##########
@@ -112,20 +115,18 @@ class SortOrder(IcebergBaseModel):
     The order of the sort fields within the list defines the order in which the sort is applied to the data.
 
     Args:
-      order_id (int): The id of the sort-order. To keep track of historical sorting
+      order_id (int): An unique id of the sort-order of a table.

Review Comment:
   I don't think we need "of a table" -- that assumes the context that uses the sort order.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org