You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "rnewson (via GitHub)" <gi...@apache.org> on 2023/11/28 16:56:33 UTC

[PR] DRAFT nouveau deb/rpm packaging [couchdb]

rnewson opened a new pull request, #4880:
URL: https://github.com/apache/couchdb/pull/4880

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] DRAFT nouveau deb/rpm packaging [couchdb]

Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on code in PR #4880:
URL: https://github.com/apache/couchdb/pull/4880#discussion_r1409512023


##########
nouveau/build.gradle:
##########
@@ -90,3 +91,33 @@ tasks.withType(AbstractArchiveTask) {
     preserveFileTimestamps = false
     reproducibleFileOrder = true
 }
+
+
+apply plugin: 'com.netflix.nebula.deb'
+apply plugin: 'com.netflix.nebula.rpm'
+apply plugin: 'com.netflix.nebula.ospackage-daemon'
+
+ospackage {
+    packageName = 'nouveau'
+
+    into '/opt/nouveau'

Review Comment:
   install prefix is not configurable for debian packages. At least, I've never seen such a thing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] DRAFT nouveau deb/rpm packaging [couchdb]

Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on PR #4880:
URL: https://github.com/apache/couchdb/pull/4880#issuecomment-1832198382

   closing as this work will be done in couchdb-pkg instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] DRAFT nouveau deb/rpm packaging [couchdb]

Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson closed pull request #4880: DRAFT nouveau deb/rpm packaging
URL: https://github.com/apache/couchdb/pull/4880


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] DRAFT nouveau deb/rpm packaging [couchdb]

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4880:
URL: https://github.com/apache/couchdb/pull/4880#discussion_r1408516654


##########
nouveau/build.gradle:
##########
@@ -90,3 +91,33 @@ tasks.withType(AbstractArchiveTask) {
     preserveFileTimestamps = false
     reproducibleFileOrder = true
 }
+
+
+apply plugin: 'com.netflix.nebula.deb'
+apply plugin: 'com.netflix.nebula.rpm'
+apply plugin: 'com.netflix.nebula.ospackage-daemon'
+
+ospackage {
+    packageName = 'nouveau'
+
+    into '/opt/nouveau'

Review Comment:
   Is not this something that could be controlled by a user-specified prefix?  I am not experienced in building Debian packages, but for example, in case of FreeBSD, the prefix for the package can be configured by the user.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] DRAFT nouveau deb/rpm packaging [couchdb]

Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4880:
URL: https://github.com/apache/couchdb/pull/4880#discussion_r1408290083


##########
nouveau/build.gradle:
##########
@@ -90,3 +91,33 @@ tasks.withType(AbstractArchiveTask) {
     preserveFileTimestamps = false
     reproducibleFileOrder = true
 }
+
+
+apply plugin: 'com.netflix.nebula.deb'
+apply plugin: 'com.netflix.nebula.rpm'
+apply plugin: 'com.netflix.nebula.ospackage-daemon'
+
+ospackage {
+    packageName = 'nouveau'
+
+    into '/opt/nouveau'
+
+    from(jar.outputs.files) {
+            into 'lib'

Review Comment:
   The indentation is off here?  At least compared to line #110 below.



##########
nouveau/build.gradle:
##########
@@ -90,3 +91,33 @@ tasks.withType(AbstractArchiveTask) {
     preserveFileTimestamps = false
     reproducibleFileOrder = true
 }
+
+
+apply plugin: 'com.netflix.nebula.deb'
+apply plugin: 'com.netflix.nebula.rpm'
+apply plugin: 'com.netflix.nebula.ospackage-daemon'
+
+ospackage {
+    packageName = 'nouveau'
+
+    into '/opt/nouveau'
+
+    from(jar.outputs.files) {
+            into 'lib'

Review Comment:
   The indentation is off here?  At least compared to line 110 below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org