You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Christian Daszenies (JIRA)" <my...@incubator.apache.org> on 2005/05/13 14:20:09 UTC

[jira] Created: (MYFACES-242) EqualValidator: Wrong Message when foreignComp.getValue()==null

EqualValidator: Wrong Message when foreignComp.getValue()==null
---------------------------------------------------------------

         Key: MYFACES-242
         URL: http://issues.apache.org/jira/browse/MYFACES-242
     Project: MyFaces
        Type: Bug
    Versions: 1.0.9 beta    
    Reporter: Christian Daszenies


consider the following structure: there are two input-fields which are both required and their value shold be equal to each other
example:
<x:input id="msisdn" value="#{...msisdn}" required="true"/>
<x:message for="msisdn" />
<x:input id="msisdnConfirm" required="true">
<x:validateEqual for="msisdn"/>	        
<x:message for="msisdnConfirm" />

if msisdn is not filled in one gets the following message
  message for="msisdn": Value is required
  message for="msisdnConfirm": The given value (xxx) is not equal with value of "msisdn".

Suggested behaviour:
The message for msisdnConfirm should not be displayed if the value for msisdn is not entered


		if(foreignComp==null)
			throw new FacesException("Unable to find component '" + _for + "' (calling findComponent on component '" + uiComponent.getId() + "')");

+		if (foreignComp.isRequired() && foreignComp.getValue()== null ) {
+			return;
+		}
		
		Object[] args = {value.toString(),(foreignComp.getValue()==null) ? foreignComp.getId():foreignComp.getValue().toString()};


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (MYFACES-242) EqualValidator: Wrong Message when foreignComp.getValue()==null

Posted by "Martin Marinschek (JIRA)" <my...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-242?page=all ]
     
Martin Marinschek closed MYFACES-242:
-------------------------------------

     Resolution: Fixed
    Fix Version: Nightly Build

Fixed, thanks for fix by Christian Daszenies!

> EqualValidator: Wrong Message when foreignComp.getValue()==null
> ---------------------------------------------------------------
>
>          Key: MYFACES-242
>          URL: http://issues.apache.org/jira/browse/MYFACES-242
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.9 beta
>     Reporter: Christian Daszenies
>     Assignee: Martin Marinschek
>      Fix For: Nightly Build

>
> consider the following structure: there are two input-fields which are both required and their value shold be equal to each other
> example:
> <x:input id="msisdn" value="#{...msisdn}" required="true"/>
> <x:message for="msisdn" />
> <x:input id="msisdnConfirm" required="true">
> <x:validateEqual for="msisdn"/>	        
> <x:message for="msisdnConfirm" />
> if msisdn is not filled in one gets the following message
>   message for="msisdn": Value is required
>   message for="msisdnConfirm": The given value (xxx) is not equal with value of "msisdn".
> Suggested behaviour:
> The message for msisdnConfirm should not be displayed if the value for msisdn is not entered
> 		if(foreignComp==null)
> 			throw new FacesException("Unable to find component '" + _for + "' (calling findComponent on component '" + uiComponent.getId() + "')");
> +		if (foreignComp.isRequired() && foreignComp.getValue()== null ) {
> +			return;
> +		}
> 		
> 		Object[] args = {value.toString(),(foreignComp.getValue()==null) ? foreignComp.getId():foreignComp.getValue().toString()};

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira