You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2015/09/16 02:12:28 UTC
[GitHub] cordova-browser pull request: CB-9669 Browser exec should have mor...
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-browser/pull/18
CB-9669 Browser exec should have more failsafes
This makes the browser exec methods consistent with other js-only platforms.
CallbackID's are used, callbacks can be 'kept' and missing proxies are logged.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-browser CB-9669
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-browser/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit 826d18d99a3f9b8d60e7d5a7c05bedb14ab055cd
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2015-09-15T23:58:26Z
More verbose execution model to match other platforms
commit 22158b234480a36a12686ce369af7fa62d587ea5
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2015-09-16T00:10:02Z
fix lint error
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-browser pull request: CB-9669 Browser exec should have mor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-browser/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-browser pull request: CB-9669 Browser exec should have mor...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-browser/pull/18#issuecomment-149378086
Sorry, yes, I looked but forgot to comment... Looks good to me! Could perhaps remove the comment referring to `CB-5806` since it isn't relevant in this context, but that's no biggie.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-browser pull request: CB-9669 Browser exec should have mor...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-browser/pull/18#issuecomment-149363770
ping @TimBarham
Can I merge this? have you had a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-browser pull request: CB-9669 Browser exec should have mor...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-browser/pull/18#issuecomment-141267151
@TimBarham - this looks like a good change to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org