You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rc...@apache.org on 2020/02/03 07:28:11 UTC
[james-project] 08/14: [Refactoring] Migrate
InMemoryMailboxIdDeserializerTest to JUnit 5
This is an automated email from the ASF dual-hosted git repository.
rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit ab69bf897d6a49cafd208c7302ebe57bbc820692
Author: Rene Cordier <rc...@linagora.com>
AuthorDate: Tue Jan 21 16:30:06 2020 +0700
[Refactoring] Migrate InMemoryMailboxIdDeserializerTest to JUnit 5
---
.../InMemoryMailboxIdDeserializerTest.java | 28 ++++++++++++----------
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/mailbox/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxIdDeserializerTest.java b/mailbox/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxIdDeserializerTest.java
index d47acd3..d0f83bc 100644
--- a/mailbox/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxIdDeserializerTest.java
+++ b/mailbox/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxIdDeserializerTest.java
@@ -20,33 +20,35 @@
package org.apache.james.mailbox.inmemory;
import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
import org.apache.james.mailbox.store.mail.model.MailboxIdDeserialisationException;
import org.apache.james.mailbox.store.mail.model.MailboxIdDeserializer;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
-public class InMemoryMailboxIdDeserializerTest {
+class InMemoryMailboxIdDeserializerTest {
- private static final String SERIALIZED_ID = "1234567890123";
- private static final String MALFORMED_SERIALIZED_ID = "aEZ";
- private static final InMemoryId IN_MEMORY_ID = InMemoryId.of(Long.parseLong(SERIALIZED_ID));
+ static final String SERIALIZED_ID = "1234567890123";
+ static final String MALFORMED_SERIALIZED_ID = "aEZ";
+ static final InMemoryId IN_MEMORY_ID = InMemoryId.of(Long.parseLong(SERIALIZED_ID));
- private MailboxIdDeserializer mailboxIdDeserializer;
+ MailboxIdDeserializer mailboxIdDeserializer;
- @Before
- public void setUp() {
+ @BeforeEach
+ void setUp() {
mailboxIdDeserializer = new InMemoryMailboxIdDeserializer();
}
@Test
- public void deserializeShouldWork() throws MailboxIdDeserialisationException {
+ void deserializeShouldWork() throws MailboxIdDeserialisationException {
assertThat(mailboxIdDeserializer.deserialize(SERIALIZED_ID)).isEqualTo(IN_MEMORY_ID);
}
- @Test(expected = MailboxIdDeserialisationException.class)
- public void deserializeShouldThrowOnMalformedData() throws MailboxIdDeserialisationException {
- mailboxIdDeserializer.deserialize(MALFORMED_SERIALIZED_ID);
+ @Test
+ void deserializeShouldThrowOnMalformedData() {
+ assertThatThrownBy(() -> mailboxIdDeserializer.deserialize(MALFORMED_SERIALIZED_ID))
+ .isInstanceOf(MailboxIdDeserialisationException.class);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org