You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "timgrein (via GitHub)" <gi...@apache.org> on 2024/03/10 10:06:34 UTC
[PR] Fix TestFloatVectorSimilarityQuery.testBoostQuery [lucene]
timgrein opened a new pull request, #13176:
URL: https://github.com/apache/lucene/pull/13176
### Description
For the following seed `gradlew test --tests TestFloatVectorSimilarityQuery.testBoostQuery -Dtests.seed=3F71A3D0594CEBC0 -Dtests.nightly=true -Dtests.locale=de-Latn-DE -Dtests.timezone=Pacific/Wallis -Dtests.asserts=true -Dtests.file.encoding=UTF-8` `TestFloatVectorSimilarityQuery.testBoostQuery` produced the following two doc scores:
- `doc 29`: `0.4278701`
- `doc 8`: `0.42787006`
With a boost factor of `5.3713555` the boosted doc scores looked like this:
- `doc 29`: `2.2982423`
- `doc 8`: `2.2982423`
So the boosted doc scores were the same due to floating point precision limitations, when multiplying the original scores with tiny differences with a fairly large multiplier.
My change removes the assertion expecting the exact order to be the same (AFAIU this won't be possible for every scores/boost configurations due to precision limitations), but rather asserts that the original doc score * boost factor and the boosted doc score are equals within a certain delta.
Test passed with seed `3F71A3D0594CEBC0`.
Closes https://github.com/apache/lucene/issues/13173.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix TestFloatVectorSimilarityQuery.testBoostQuery [lucene]
Posted by "benwtrent (via GitHub)" <gi...@apache.org>.
benwtrent merged PR #13176:
URL: https://github.com/apache/lucene/pull/13176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org