You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@jspwiki.apache.org by "Gardner, Mike" <Mi...@crowncastle.com> on 2019/12/10 13:20:29 UTC
Adding or Modifying a Change Note
We have wiki users who often forget to add a Change Note despite repeated haranguings to please do so. I've tired of being the school marm wagging my finger at them.
How can we add or modify a Change Note after the fact? I don't see a way to do it in the UI.
Thanks,
Mike
This email may contain confidential or privileged material. Use or disclosure of it by anyone other than the recipient is unauthorized. If you are not an intended recipient, please delete this email.
RE: Adding or Modifying a Change Note
Posted by "Gardner, Mike" <Mi...@crowncastle.com>.
Thank you, Dirk. I'll look to apply your JSP suggestion.
Perhaps I should file two Jira improvement suggestions?
- A property to make the Change Note a mandatory field.
- Some ability to modify the Change Note after-the-fact, like you can for a commit comment in Git or Subversion. Sometimes, the entered text is ... shall we say ... lacking. (And even if we make the Change Note mandatory going forward, I'm still left with something of a legacy of missing or ineffective notes that I may selectively clean up, for example, for the Recent Changes page.)
My appreciation to those who responded.
Mike
-----Original Message-----
From: Dirk Frederickx <di...@gmail.com>
Sent: Tuesday, December 10, 2019 2:20 PM
To: user@jspwiki.apache.org
Subject: Re: Adding or Modifying a Change Note
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Hi,
Currently indeed the change-note on a page-edit is an optional field.
It is not hard to make it a required field; if you are ready to modify a JSP.
Here is how:
1)
Open /templates/default/editors/plain.jsp
2)
Add a 'required' attribute to the CHANGENOTE input field
<input class="form-control" type="text" name="changenote"
id="changenote" size="80" maxlength="80"
placeholder="<fmt:message key='editor.plain.changenote'/>"
required
value="${changenote}" />
3)
Add a 'formnovalidate' attribute to the CANCEL button of the editor.
(otherwise you cannot cancel the form without giving a 'bogus' change-note
:-) )
<input class="btn btn-danger pull-right" type="submit" name="cancel"
accesskey="q"
value="<fmt:message key='editor.plain.cancel.submit'/>"
title="<fmt:message key='editor.plain.cancel.title'/>"
formnovalidate />
Good luck !
Could you log a JIRA improvement request, so we can consider to make this a JSPWIKI property.
Best regards,
dirk
On Tue, Dec 10, 2019 at 2:40 PM Ulf Dittmer <ul...@googlemail.com.invalid> wrote:
> I would like to have an option to make a non-empty change comment
> mandatory! A quick search through jspwiki.properties comes up empty,
> so I don't think this is possible right now.
>
> Ulf
>
> On Tue, Dec 10, 2019 at 2:29 PM Col Willis <co...@gmail.com> wrote:
>
> > It might be better to ensure a change note is mandatory for a given
> submit?
> >
> > Unsure if this is currently supported though?
> >
> >
> > On Tue, 10 Dec 2019, 13:23 Gardner, Mike,
> > <Mike.Gardner@crowncastle.com
> > > wrote:
> >
> > > We have wiki users who often forget to add a Change Note despite
> repeated
> > > haranguings to please do so. I've tired of being the school marm
> > wagging > my finger at them.
> > >
> > > How can we add or modify a Change Note after the fact? I don't
> > > see a
> > way to do it in the UI.
> > >
> >
>
This email may contain confidential or privileged material. Use or disclosure of it by anyone other than the recipient is unauthorized. If you are not an intended recipient, please delete this email.
Re: Adding or Modifying a Change Note
Posted by Dirk Frederickx <di...@gmail.com>.
Hi,
Currently indeed the change-note on a page-edit is an optional field.
It is not hard to make it a required field; if you are ready to modify a
JSP.
Here is how:
1)
Open /templates/default/editors/plain.jsp
2)
Add a 'required' attribute to the CHANGENOTE input field
<input class="form-control" type="text" name="changenote"
id="changenote" size="80" maxlength="80"
placeholder="<fmt:message key='editor.plain.changenote'/>"
required
value="${changenote}" />
3)
Add a 'formnovalidate' attribute to the CANCEL button of the editor.
(otherwise you cannot cancel the form without giving a 'bogus' change-note
:-) )
<input class="btn btn-danger pull-right" type="submit" name="cancel"
accesskey="q"
value="<fmt:message key='editor.plain.cancel.submit'/>"
title="<fmt:message key='editor.plain.cancel.title'/>"
formnovalidate />
Good luck !
Could you log a JIRA improvement request, so we can consider to make this a
JSPWIKI property.
Best regards,
dirk
On Tue, Dec 10, 2019 at 2:40 PM Ulf Dittmer
<ul...@googlemail.com.invalid> wrote:
> I would like to have an option to make a non-empty change comment
> mandatory! A quick search through jspwiki.properties comes up empty, so I
> don't think this is possible right now.
>
> Ulf
>
> On Tue, Dec 10, 2019 at 2:29 PM Col Willis <co...@gmail.com> wrote:
>
> > It might be better to ensure a change note is mandatory for a given
> submit?
> >
> > Unsure if this is currently supported though?
> >
> >
> > On Tue, 10 Dec 2019, 13:23 Gardner, Mike, <Mike.Gardner@crowncastle.com
> > > wrote:
> >
> > > We have wiki users who often forget to add a Change Note despite
> repeated
> > > haranguings to please do so. I've tired of being the school marm
> > wagging > my finger at them.
> > >
> > > How can we add or modify a Change Note after the fact? I don't see a
> > way to do it in the UI.
> > >
> >
>
Re: Adding or Modifying a Change Note
Posted by Ulf Dittmer <ul...@googlemail.com.INVALID>.
I would like to have an option to make a non-empty change comment
mandatory! A quick search through jspwiki.properties comes up empty, so I
don't think this is possible right now.
Ulf
On Tue, Dec 10, 2019 at 2:29 PM Col Willis <co...@gmail.com> wrote:
> It might be better to ensure a change note is mandatory for a given submit?
>
> Unsure if this is currently supported though?
>
>
> On Tue, 10 Dec 2019, 13:23 Gardner, Mike, <Mike.Gardner@crowncastle.com
> > wrote:
>
> > We have wiki users who often forget to add a Change Note despite repeated
> > haranguings to please do so. I've tired of being the school marm
> wagging > my finger at them.
> >
> > How can we add or modify a Change Note after the fact? I don't see a
> way to do it in the UI.
> >
>
Re: Adding or Modifying a Change Note
Posted by Col Willis <co...@gmail.com>.
It might be better to ensure a change note is mandatory for a given submit?
Unsure if this is currently supported though?
On Tue, 10 Dec 2019, 13:23 Gardner, Mike, <Mi...@crowncastle.com>
wrote:
> We have wiki users who often forget to add a Change Note despite repeated
> haranguings to please do so. I've tired of being the school marm wagging
> my finger at them.
>
> How can we add or modify a Change Note after the fact? I don't see a way
> to do it in the UI.
>
> Thanks,
> Mike
>
> This email may contain confidential or privileged material. Use or
> disclosure of it by anyone other than the recipient is unauthorized. If you
> are not an intended recipient, please delete this email.
>