You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/04 15:17:22 UTC
[GitHub] [tvm] lhutton1 opened a new pull request #9831: [microNPU] Ensure optimization passes are running in compilation pipeline
lhutton1 opened a new pull request #9831:
URL: https://github.com/apache/tvm/pull/9831
Follow up to #9793. In checking this it was found that both the layout and LUT optimizer passes were silently not running. This is fixed by converting each pass to a module pass, rather than a function pass. Tests have been added to prevent this happening in the future.
cc @ekalda @manupa-arm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ekalda commented on pull request #9831: [microNPU] Ensure optimization passes are running in compilation pipeline
Posted by GitBox <gi...@apache.org>.
ekalda commented on pull request #9831:
URL: https://github.com/apache/tvm/pull/9831#issuecomment-1009861760
(Forgot to say that dealing with `function_pass` is a stuff for other PRs, this one looks good to me!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #9831: [microNPU] Ensure optimization passes are running in compilation pipeline
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on pull request #9831:
URL: https://github.com/apache/tvm/pull/9831#issuecomment-1015303815
Agreed, that makes more sense :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #9831: [microNPU] Move optimization passes to be a module pass and ensure they are running
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on pull request #9831:
URL: https://github.com/apache/tvm/pull/9831#issuecomment-1017758899
friendly ping for approval/comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #9831: [microNPU] Ensure optimization passes are running in compilation pipeline
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9831:
URL: https://github.com/apache/tvm/pull/9831#issuecomment-1009937435
kCompiler (a.k.a. "Compiler") attribute generally blocks most passes from visiting the function body. Are we saying there was a time where the pass worked even when the kCompiler is set ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ekalda commented on pull request #9831: [microNPU] Ensure optimization passes are running in compilation pipeline
Posted by GitBox <gi...@apache.org>.
ekalda commented on pull request #9831:
URL: https://github.com/apache/tvm/pull/9831#issuecomment-1009951237
I saw the LUT pass working as a part of a pipeline when I was developing it (I first developed it by running an end to end codegen test with a breakpoint before the pass and checked that the Relay had changed as expected after stepping over it). Out of interest, why does the `kCompiler` attribute block the passes visiting the function body?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #9831: [microNPU] Ensure optimization passes are running in compilation pipeline
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on pull request #9831:
URL: https://github.com/apache/tvm/pull/9831#issuecomment-1009889572
Thanks @ekalda for taking a look, yes it seems quite strange to me. Just wanted to note that `function_pass` is used outside of tutorials, I was foolishly searching for `relay.transform.function_pass` rather than just `function_pass` :)
I did a little bit more digging and it seems like the `function_pass` doesn't get run on a function when there is a `"Compiler"` attribute associated with it. I wonder if this is intended behavior and if/when this changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #9831: [microNPU] Move optimization passes to be a module pass and ensure they are running
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9831:
URL: https://github.com/apache/tvm/pull/9831#issuecomment-1017789399
Thanks @lhutton1 @ekalda !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #9831: [microNPU] Ensure optimization passes are running in compilation pipeline
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on pull request #9831:
URL: https://github.com/apache/tvm/pull/9831#issuecomment-1010202679
Thanks @manupa-arm, in that case it sounds like migrating to a module pass is the correct thing to do here. It's still a bit of a mystery as to why @ekalda and I believe this used to work, although its probably worth not dwelling on it for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #9831: [microNPU] Ensure optimization passes are running in compilation pipeline
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #9831:
URL: https://github.com/apache/tvm/pull/9831#issuecomment-1010013664
It is used to annotate relay functions meant to be compiled with BYOC. Therefore, the compilation passes of core compiler ignores it. IIRC, that was the reason.
I believe this affects function pass because (and not module pass) the pass it self does not choose which functions to mutate as opposed to a module pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm merged pull request #9831: [microNPU] Move optimization passes to be a module pass and ensure they are running
Posted by GitBox <gi...@apache.org>.
manupa-arm merged pull request #9831:
URL: https://github.com/apache/tvm/pull/9831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org