You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/13 11:07:24 UTC

[GitHub] [incubator-seatunnel] 531651225 opened a new pull request, #2404: [Feature][Connector-V2] Add Enterprise WeChart source

531651225 opened a new pull request, #2404:
URL: https://github.com/apache/incubator-seatunnel/pull/2404

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   related to https://github.com/apache/incubator-seatunnel/issues/1946
   ## Purpose of this pull request
   Add Enterprise WeChart source
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] 531651225 commented on pull request #2404: [Feature][Connector-V2] Add Enterprise WeChart source

Posted by GitBox <gi...@apache.org>.
531651225 commented on PR #2404:
URL: https://github.com/apache/incubator-seatunnel/pull/2404#issuecomment-1214261948

   > If you want to implement a connector like webhook, you can refer feishu sink implementation. First you should extends `connector-http-base`, then extends `HttpSink` and finally rewrite you logic in your class. By the way, in `connector-http-base` we had wrapped a http util so you need not add new http dependency additionally.
   
   Thx for your good advice，i will try


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] 531651225 closed pull request #2404: [Feature][Connector-V2] Add Enterprise WeChart source

Posted by GitBox <gi...@apache.org>.
531651225 closed pull request #2404: [Feature][Connector-V2] Add Enterprise WeChart source
URL: https://github.com/apache/incubator-seatunnel/pull/2404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #2404: [Feature][Connector-V2] Add Enterprise WeChart source

Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #2404:
URL: https://github.com/apache/incubator-seatunnel/pull/2404#issuecomment-1214288941

   > > If you want to implement a connector like webhook, you can refer feishu sink implementation. First you should extends `connector-http-base`, then extends `HttpSink` and finally rewrite you logic in your class. By the way, in `connector-http-base` we had wrapped a http util so you need not add new http dependency additionally.
   > 
   > Thx for your good advice，i will try
   
   Waiting for your contribution.😄


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #2404: [Feature][Connector-V2] Add Enterprise WeChart source

Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #2404:
URL: https://github.com/apache/incubator-seatunnel/pull/2404#issuecomment-1214142335

   If you want to implement a connector like webhook, you can refer feishu sink implementation.  You should extends `connector-http-base` and extends `HttpSink` and rewrite you logic in your class, by the way, in `connector-http-base` we had wrapped a http util.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org