You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by pi...@apache.org on 2021/08/13 04:39:43 UTC

[submarine] branch master updated: SUBMARINE-974. Update how to contribute page

This is an automated email from the ASF dual-hosted git repository.

pingsutw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new 54d3cdc  SUBMARINE-974. Update how to contribute page
54d3cdc is described below

commit 54d3cdc681c5ab8b619b7a599a4d7b100db91a34
Author: KUAN-HSUN-LI <b0...@ntu.edu.tw>
AuthorDate: Fri Aug 13 10:41:06 2021 +0800

    SUBMARINE-974. Update how to contribute page
    
    ### What is this PR for?
    Update the CI check in 'how to contribute to submarine' page
    
    ### What type of PR is it?
    [Documentation]
    
    ### Todos
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/SUBMARINE-974
    
    ### How should this be tested?
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Do the license files need updating? No
    * Are there breaking changes for older versions? No
    * Does this need new documentation? No
    
    Author: KUAN-HSUN-LI <b0...@ntu.edu.tw>
    
    Signed-off-by: Kevin <pi...@apache.org>
    
    Closes #706 from KUAN-HSUN-LI/SUBMARINE-974 and squashes the following commits:
    
    f2dbdafd [KUAN-HSUN-LI] SUBMARINE-974. Update how to contribute page
    47181190 [KUAN-HSUN-LI] SUBMARINE-974. Update how to contribute page
---
 website/docs/assets/check_ci_pass.png  | Bin 0 -> 74693 bytes
 website/docs/community/contributing.md |  14 ++++++++------
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/website/docs/assets/check_ci_pass.png b/website/docs/assets/check_ci_pass.png
new file mode 100644
index 0000000..4e80fa8
Binary files /dev/null and b/website/docs/assets/check_ci_pass.png differ
diff --git a/website/docs/community/contributing.md b/website/docs/community/contributing.md
index faa50f9..cac1c86 100644
--- a/website/docs/community/contributing.md
+++ b/website/docs/community/contributing.md
@@ -103,9 +103,11 @@ git rebase upstream/master
 git push origin SUBMARINE-${jira_number} 
 ```
 
-### Step8: Check Travis-ci status of your personal fork
-* Visit `https://travis-ci.com/github/${USERNAME}/submarine`
-* Please make sure your new commits can pass all integration tests before creating a pull request.
+### Step8: Check GitHub Actions status of your personal commit
+* Visit `https://github.com/${USERNAME}/submarine/actions`
+* Please make sure your new commits can pass all workflows before creating a pull request.
+
+![check_ci_pass](../assets/check_ci_pass.png)
 
 ### Step9: Create a pull request on github UI
 * Visit your fork at `https://github.com/${USERNAME}/submarine.git`
@@ -118,9 +120,9 @@ git push origin SUBMARINE-${jira_number}
 
 ![pull_request_template_example](../assets/pull_request_template_example.png)
 
-### Step10: Check Travis-ci status of your pull request in apache/submarine
-* Visit https://travis-ci.com/github/apache/submarine/pull_requests
-* Please make sure your pull request can pass all integration tests. 
+### Step10: Check GitHub Actions status of your pull request in apache/submarine
+* Visit https://github.com/apache/submarine/actions
+* Please make sure your pull request can pass all workflows. 
 
 ### Step11: The Review Process
 * Anyone can be a reviewer and comment on the pull requests.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org