[jira] [Commented] (KAFKA-20389) ConfigKeyInfo does not include 'internal' flag.

["Mickael Maison (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-20389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18072066#comment-18072066 ] 

Mickael Maison commented on KAFKA-20389:
----------------------------------------

Instead of adding an internal flag to ConfigKeyInfo, I think GET /connectors/<CONNECTOR>/config and GET /connector-plugins/<CONNECTOR>/config should not return internal configs. If a config is marked as internal it should not be exposed.

> ConfigKeyInfo does not include 'internal' flag.
> -----------------------------------------------
>
>                 Key: KAFKA-20389
>                 URL: https://issues.apache.org/jira/browse/KAFKA-20389
>             Project: Kafka
>          Issue Type: Improvement
>          Components: connect
>    Affects Versions: 4.1.2
>            Reporter: Claude Warren
>            Assignee: Nilesh Kumar
>            Priority: Minor
>
> ConnectorPluginsResource in response to a "GET /plugin_name/config" call returns a list of ConfigKeyInfo objects.
> The ConfigKeyInfo object does not contain the internal flag value from the ConfigKey
> the ConnectorPluginsResource.getConnectorConfigDef() which implements the GET noted above does not filter the internal configurations out.
> We have a need to be able to filter out the internal records from the list.
> As the method is part of the public API changing the functionality of it is not proper, so I would like to add the internal flag to the data returned in the ConfigKeyInfo.  Since this gets converted into JSON I don't think that there will be an impact on users who are not expecting the field.
> Are there issues with this approach?
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)