You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by jianqiao <gi...@git.apache.org> on 2018/02/26 19:19:30 UTC
[GitHub] incubator-quickstep pull request #334: Fix iwyu include path
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/334
Fix iwyu include path
This PR fixes the third-party library include paths for the iwyu (include-what-you-use) tool.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep fix-iwyu
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/334.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #334
----
commit c2ed5c69b6b8dad07d7410beb0c8292ea1a746e0
Author: Jianqiao Zhu <ji...@...>
Date: 2017-09-01T20:07:41Z
Fix iwyu include path
----
---
[GitHub] incubator-quickstep issue #334: Fix iwyu include path
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/334
Hi @jianqiao
This looks good to me. Have you been actively using the IWYU library? I stopped using it a while ago because of the false positives. I am not sure if it has improved.
---
[GitHub] incubator-quickstep issue #334: Fix iwyu include path
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/334
Merged.
---
[GitHub] incubator-quickstep pull request #334: Fix iwyu include path
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/334
---