You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/19 03:09:43 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38292: [SPARK-40779][PS][TEST] Fix `corrwith` to work properly with different anchor.

HyukjinKwon commented on code in PR #38292:
URL: https://github.com/apache/spark/pull/38292#discussion_r998900029


##########
python/pyspark/pandas/tests/test_ops_on_diff_frames.py:
##########
@@ -1866,17 +1866,23 @@ def test_corrwith(self):
         self._test_corrwith((df1 + 1), df2.B)
         self._test_corrwith((df1 + 1), (df2.B + 2))
 
-        df_bool = ps.DataFrame({"A": [True, True, False, False], "B": [True, False, False, True]})
-        ser_bool = ps.Series([True, True, False, True])
-        self._test_corrwith(df_bool, ser_bool)
+        # Regression in pandas 1.5.0

Review Comment:
   Can we add if-else?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org