You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/13 06:10:52 UTC
[GitHub] [incubator-druid] clintropolis commented on issue #7647: fix lookup
editor to use lookup tiers instead of historical tiers
clintropolis commented on issue #7647: fix lookup editor to use lookup tiers instead of historical tiers
URL: https://github.com/apache/incubator-druid/pull/7647#issuecomment-491688667
>Per your comments in #7646 it might make sense to turn the tiers into a free form input. It might make sense to that the "input with suggestions" that is currently inlined in the AutoForm (https://github.com/apache/incubator-druid/blob/master/web-console/src/components/auto-form.tsx#L146) and turn it into a component InputWithSuggestions or SuggestableInput (?) and then reuse it in https://github.com/apache/incubator-druid/blob/master/web-console/src/dialogs/lookup-edit-dialog.tsx#L71 also. Thoughts?
I think this sounds reasonable, though perhaps as a follow-up to this PR to split the refactoring from this fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org