You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/11/24 06:44:25 UTC
Re: Review Request 40532: Added notion of evictable task to
RunTaskMessage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/
-----------------------------------------------------------
(Updated 十一月 24, 2015, 5:44 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Summary (updated)
-----------------
Added notion of evictable task to RunTaskMessage.
Bugs: MESOS-3890
https://issues.apache.org/jira/browse/MESOS-3890
Repository: mesos
Description
-------
Added notion of evictable task to RunTaskMessage.
Diffs
-----
src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a
Diff: https://reviews.apache.org/r/40532/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40532: Added notion of evictable task to
RunTaskMessage.
Posted by Guangya Liu <gy...@gmail.com>.
> On 十二月 1, 2015, 1:31 a.m., Joseph Wu wrote:
> > src/messages/messages.proto, lines 326-329
> > <https://reviews.apache.org/r/40532/diff/5/?file=1146569#file1146569line326>
> >
> > The design doc comment doesn't quite work without the context surrounding it. :)
> >
> > ---
> > Suggestion:
> >
> > When a task is launched on reserved resources, this list contains some executors that have oversubscribed the same reserved resources. The agent can evict these executors to make room for the task.
> >
> > This list is always empty when the task launch does not involve reserved resources (oversubscribed reserved resources are considered "revocable resources").
Done, thanks Joseph!
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/#review108436
-----------------------------------------------------------
On 十一月 25, 2015, 7:31 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40532/
> -----------------------------------------------------------
>
> (Updated 十一月 25, 2015, 7:31 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-3890
> https://issues.apache.org/jira/browse/MESOS-3890
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added notion of evictable task to RunTaskMessage.
>
>
> Diffs
> -----
>
> src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a
>
> Diff: https://reviews.apache.org/r/40532/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40532: Added notion of evictable task to
RunTaskMessage.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/#review108436
-----------------------------------------------------------
src/messages/messages.proto (lines 326 - 329)
<https://reviews.apache.org/r/40532/#comment167895>
The design doc comment doesn't quite work without the context surrounding it. :)
---
Suggestion:
When a task is launched on reserved resources, this list contains some executors that have oversubscribed the same reserved resources. The agent can evict these executors to make room for the task.
This list is always empty when the task launch does not involve reserved resources (oversubscribed reserved resources are considered "revocable resources").
- Joseph Wu
On Nov. 24, 2015, 11:31 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40532/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 11:31 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-3890
> https://issues.apache.org/jira/browse/MESOS-3890
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added notion of evictable task to RunTaskMessage.
>
>
> Diffs
> -----
>
> src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a
>
> Diff: https://reviews.apache.org/r/40532/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40532: Added notion of evictable task to
RunTaskMessage.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/
-----------------------------------------------------------
(Updated 一月 3, 2016, 9:34 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3890
https://issues.apache.org/jira/browse/MESOS-3890
Repository: mesos
Description
-------
Added notion of evictable task to RunTaskMessage.
Diffs
-----
src/messages/messages.proto b66bac14056407140bb3cf5aa3e67ac94df1a2f8
Diff: https://reviews.apache.org/r/40532/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40532: Added notion of evictable task to
RunTaskMessage.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/#review109765
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40375, 40339, 40529, 40632, 40532]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 10, 2015, 2:26 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40532/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 2:26 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-3890
> https://issues.apache.org/jira/browse/MESOS-3890
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added notion of evictable task to RunTaskMessage.
>
>
> Diffs
> -----
>
> src/messages/messages.proto b66bac14056407140bb3cf5aa3e67ac94df1a2f8
>
> Diff: https://reviews.apache.org/r/40532/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40532: Added notion of evictable task to
RunTaskMessage.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/#review109894
-----------------------------------------------------------
Ship it!
Ship It!
- Klaus Ma
On Dec. 10, 2015, 10:26 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40532/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 10:26 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-3890
> https://issues.apache.org/jira/browse/MESOS-3890
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added notion of evictable task to RunTaskMessage.
>
>
> Diffs
> -----
>
> src/messages/messages.proto b66bac14056407140bb3cf5aa3e67ac94df1a2f8
>
> Diff: https://reviews.apache.org/r/40532/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40532: Added notion of evictable task to
RunTaskMessage.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/
-----------------------------------------------------------
(Updated 十二月 10, 2015, 2:26 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3890
https://issues.apache.org/jira/browse/MESOS-3890
Repository: mesos
Description
-------
Added notion of evictable task to RunTaskMessage.
Diffs (updated)
-----
src/messages/messages.proto b66bac14056407140bb3cf5aa3e67ac94df1a2f8
Diff: https://reviews.apache.org/r/40532/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40532: Added notion of evictable task to
RunTaskMessage.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/
-----------------------------------------------------------
(Updated 十二月 10, 2015, 8:34 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3890
https://issues.apache.org/jira/browse/MESOS-3890
Repository: mesos
Description
-------
Added notion of evictable task to RunTaskMessage.
Diffs (updated)
-----
src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a
Diff: https://reviews.apache.org/r/40532/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40532: Added notion of evictable task to
RunTaskMessage.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/#review108789
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40339, 40529, 40532]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 3, 2015, 4:35 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40532/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 4:35 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-3890
> https://issues.apache.org/jira/browse/MESOS-3890
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added notion of evictable task to RunTaskMessage.
>
>
> Diffs
> -----
>
> src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a
>
> Diff: https://reviews.apache.org/r/40532/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 40532: Added notion of evictable task to
RunTaskMessage.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/
-----------------------------------------------------------
(Updated 十二月 3, 2015, 4:35 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3890
https://issues.apache.org/jira/browse/MESOS-3890
Repository: mesos
Description
-------
Added notion of evictable task to RunTaskMessage.
Diffs (updated)
-----
src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a
Diff: https://reviews.apache.org/r/40532/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40532: Added notion of evictable task to
RunTaskMessage.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/
-----------------------------------------------------------
(Updated 十一月 25, 2015, 7:31 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-3890
https://issues.apache.org/jira/browse/MESOS-3890
Repository: mesos
Description
-------
Added notion of evictable task to RunTaskMessage.
Diffs (updated)
-----
src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a
Diff: https://reviews.apache.org/r/40532/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40532: Added notion of evictable task to
RunTaskMessage.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/
-----------------------------------------------------------
(Updated 十一月 24, 2015, 8:09 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Changes
-------
Rebase
Bugs: MESOS-3890
https://issues.apache.org/jira/browse/MESOS-3890
Repository: mesos
Description
-------
Added notion of evictable task to RunTaskMessage.
Diffs (updated)
-----
src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a
Diff: https://reviews.apache.org/r/40532/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 40532: Added notion of evictable task to
RunTaskMessage.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40532/#review107727
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40339, 40524, 40529, 40532]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 24, 2015, 5:44 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40532/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 5:44 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-3890
> https://issues.apache.org/jira/browse/MESOS-3890
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added notion of evictable task to RunTaskMessage.
>
>
> Diffs
> -----
>
> src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a
>
> Diff: https://reviews.apache.org/r/40532/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>