You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sourabh Goyal (Code Review)" <ge...@cloudera.org> on 2021/11/09 10:33:27 UTC
[Impala-ASF-CR] [DO NOT MERGE]: IMPALA-10926: Test patchset:24 - set last synced event id when processing self event
Sourabh Goyal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18005
Change subject: [DO NOT MERGE]: IMPALA-10926: Test patchset:24 - set last synced event id when processing self event
......................................................................
[DO NOT MERGE]: IMPALA-10926: Test patchset:24 - set last synced event id
when processing self event
Change-Id: I439f59b25c6b01f9f14a0cb58d48a700d627cd91
---
M be/src/catalog/catalog-server.cc
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/Db.java
M fe/src/main/java/org/apache/impala/catalog/Table.java
M fe/src/main/java/org/apache/impala/catalog/TableLoader.java
M fe/src/main/java/org/apache/impala/catalog/events/EventFactory.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/catalog/events/NoOpEventProcessor.java
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/HmsApiNameEnum.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M fe/src/test/java/org/apache/impala/catalog/AlterDatabaseTest.java
A fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
M fe/src/test/java/org/apache/impala/catalog/events/EventsProcessorStressTest.java
M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M fe/src/test/java/org/apache/impala/catalog/events/SynchronousHMSEventProcessorForTests.java
M fe/src/test/java/org/apache/impala/catalog/metastore/AbstractCatalogMetastoreTest.java
A fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java
M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
M tests/custom_cluster/test_metastore_service.py
26 files changed, 3,495 insertions(+), 283 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/18005/1
--
To view, visit http://gerrit.cloudera.org:8080/18005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I439f59b25c6b01f9f14a0cb58d48a700d627cd91
Gerrit-Change-Number: 18005
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
[Impala-ASF-CR] [DO NOT MERGE]: IMPALA-10926: Test patchset:24 - set last synced event id when processing self event
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18005 )
Change subject: [DO NOT MERGE]: IMPALA-10926: Test patchset:24 - set last synced event id when processing self event
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9741/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I439f59b25c6b01f9f14a0cb58d48a700d627cd91
Gerrit-Change-Number: 18005
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Nov 2021 10:55:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DO NOT MERGE]: IMPALA-10926: Test patchset:24 - set last synced event id when processing self event
Posted by "Sourabh Goyal (Code Review)" <ge...@cloudera.org>.
Sourabh Goyal has abandoned this change. ( http://gerrit.cloudera.org:8080/18005 )
Change subject: [DO NOT MERGE]: IMPALA-10926: Test patchset:24 - set last synced event id when processing self event
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/18005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I439f59b25c6b01f9f14a0cb58d48a700d627cd91
Gerrit-Change-Number: 18005
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [DO NOT MERGE]: IMPALA-10926: Test patchset:24 - set last synced event id when processing self event
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18005 )
Change subject: [DO NOT MERGE]: IMPALA-10926: Test patchset:24 - set last synced event id when processing self event
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18005/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java:
http://gerrit.cloudera.org:8080/#/c/18005/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2452
PS1, Line 2452: batchEvents = eventFactory.createBatchEvents(mockEvents, eventsProcessor_.getMetrics());
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/18005/1/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java
File fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java:
http://gerrit.cloudera.org:8080/#/c/18005/1/fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java@85
PS1, Line 85: private static boolean flagEnableCatalogCache ,flagInvalidateCache, flagSyncToLatestEventId;
line too long (96 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I439f59b25c6b01f9f14a0cb58d48a700d627cd91
Gerrit-Change-Number: 18005
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Nov 2021 10:34:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DO NOT MERGE]: IMPALA-10926: Test patchset:24 - set last synced event id when processing self event
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18005 )
Change subject: [DO NOT MERGE]: IMPALA-10926: Test patchset:24 - set last synced event id when processing self event
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I439f59b25c6b01f9f14a0cb58d48a700d627cd91
Gerrit-Change-Number: 18005
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Nov 2021 16:56:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DO NOT MERGE]: IMPALA-10926: Test patchset:24 - set last synced event id when processing self event
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18005 )
Change subject: [DO NOT MERGE]: IMPALA-10926: Test patchset:24 - set last synced event id when processing self event
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7611/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I439f59b25c6b01f9f14a0cb58d48a700d627cd91
Gerrit-Change-Number: 18005
Gerrit-PatchSet: 1
Gerrit-Owner: Sourabh Goyal <so...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Nov 2021 10:34:21 +0000
Gerrit-HasComments: No