You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2015/10/22 12:38:28 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-908 Use line breaks i...
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/118
TINKERPOP3-908 Use line breaks in documentation
This PR isn't ready for VOTE. I opened this PR more for collaboration. While all the line breaks have been added, there is a problem in doc generation I can't figure out with: `the-traversal.asciidoc`. Doc generation is failing there.
@dkuppitz can you please take a look - i'm just not seeing what's wrong. Once we get the docs generating, we can put this PR up for VOTE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-908
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/118.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #118
----
commit cad968e2ad85ba8645de5c133827f59fbe8ac0f5
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-10-22T10:24:18Z
TINKERPOP3-907 Added line breaks to all docs.
Getting a failure on the-traversal during doc generation, but not sure what the problems is.
commit 7bf9b0952476218a47589781a57b551060f8ce5d
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2015-10-22T10:32:56Z
Trying an empty commit to see if it will force the branch to synch with mirror.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-908 Use line breaks i...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/118#issuecomment-150909685
Not sure if the changes had the desired effect, but the docs can be built fine.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-908 Use line breaks i...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/118#issuecomment-150181052
Aha - this is failing without the line breaks! Switched back to master and still get:
```text
* source: /home/smallette/git/apache/incubator-tinkerpop/docs/src/the-traversal.asciidoc
target: /home/smallette/git/apache/incubator-tinkerpop/target/postprocess-asciidoc/the-traversal.asciidoc
progress: [================================================================> ] 64%No such property: keys for class: e
Display stack trace? [yN] g.V().hasLabel('song').out('followedBy').groupCount().by('name').
groovysh_parse: 3: expecting EOF, found ')' @ line 3, column 11.
f.exists()) f.deleteDir()
```
Anyone know what this is? please fix in this branch if you know the problem that way we can merge back to master cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-908 Use line breaks i...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/118#issuecomment-150336659
yeah - i got past that issue - stuck on giraph execution now. something fishy with my hadoop2 stuff. this was working for me before - i guess something must have changed in giraph.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-908 Use line breaks i...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/118#issuecomment-150328532
This worked for me locally. VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-908 Use line breaks i...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/118#issuecomment-150335848
`the-traversal.asciidoc` also worked for me (I didn't try the others as I still have to set up my Hadoop 2 environment first; will do that the coming weekend). Hence, I can tell that the error mentioned above is not a general problem in the docs, but I can't vote yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-908 Use line breaks i...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/118#issuecomment-150923282
Got my docs generating: +1
RESULT: +1 (3) merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-908 Use line breaks i...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/118#issuecomment-150346978
Giraph hasn't changed since the update to 2.0 Hadoop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-908 Use line breaks i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/118
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---