You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "FMX (via GitHub)" <gi...@apache.org> on 2023/03/13 02:39:09 UTC
[GitHub] [incubator-celeborn] FMX opened a new pull request, #1329: [CELEBORN-403][FLINK] Add metrics about buffer dispatcher requests queue length.
FMX opened a new pull request, #1329:
URL: https://github.com/apache/incubator-celeborn/pull/1329
### What changes were proposed in this pull request?
To show metrics about buffer dispatcher requests queue length.
### Why are the changes needed?
To show the busyness of workers in allocating read memory.
### Does this PR introduce _any_ user-facing change?
NO.
### How was this patch tested?
PR and cluster run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1329: [CELEBORN-403][FLINK] Add metrics about buffer dispatcher requests queue length.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1329:
URL: https://github.com/apache/incubator-celeborn/pull/1329#issuecomment-1465429614
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1329?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1329](https://codecov.io/gh/apache/incubator-celeborn/pull/1329?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a240cb0) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/c6eced69fceb4f0ec56b35a0b5fc0e91c2938d3a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6eced6) will **decrease** coverage by `0.00%`.
> The diff coverage is `6.67%`.
```diff
@@ Coverage Diff @@
## main #1329 +/- ##
============================================
- Coverage 27.79% 27.78% -0.00%
Complexity 842 842
============================================
Files 221 221
Lines 18459 18465 +6
Branches 1979 1979
============================================
+ Hits 5128 5129 +1
- Misses 12976 12981 +5
Partials 355 355
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rn/common/network/server/memory/MemoryManager.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zZXJ2ZXIvbWVtb3J5L01lbW9yeU1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...on/network/server/memory/ReadBufferDispatcher.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zZXJ2ZXIvbWVtb3J5L1JlYWRCdWZmZXJEaXNwYXRjaGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...apache/celeborn/service/deploy/worker/Worker.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL1dvcmtlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [.../celeborn/service/deploy/worker/WorkerSource.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1329?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL1dvcmtlclNvdXJjZS5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1329: [CELEBORN-403][FLINK] Add metrics about buffer dispatcher requests queue length.
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1329:
URL: https://github.com/apache/incubator-celeborn/pull/1329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org