You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/09/06 18:06:08 UTC
[GitHub] [druid] abhishekagarwal87 opened a new pull request #11664: [WIP] Support passing context params via JDBC URL
abhishekagarwal87 opened a new pull request #11664:
URL: https://github.com/apache/druid/pull/11664
This PR adds support for passing context parameters via JDBC URL. The server will parse the query parameters out of the URL and store them in a thread-local state object that can be later used by `DruidMeta` to build the query context.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis edited a comment on pull request #11664: Support passing query context params via JDBC URL
Posted by GitBox <gi...@apache.org>.
clintropolis edited a comment on pull request #11664:
URL: https://github.com/apache/druid/pull/11664#issuecomment-915557641
#10184 suggests that this should be handled by Avatica, did we investigate that avenue to support jdbc uri parameters? Or is that a different issue? (I haven't really looked at this PR yet).
I guess even if is the same issue, since the upstream issue has not been resolved yet considering how long this has been open it is reasonable to consider having some workaround here, but it does sort of seem conceptually like something that should be handled by Avatica so I wonder if it would be easier and more proper to fix there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #11664: Support passing query context params via JDBC URL
Posted by GitBox <gi...@apache.org>.
clintropolis commented on pull request #11664:
URL: https://github.com/apache/druid/pull/11664#issuecomment-915557641
#10184 suggests that this should be handled by Avatica, did we investigate that avenue to support jdbc uri parameters? Or is that a different issue? I guess even if is the same issue, since the upstream issue has not been resolved yet considering how long this has been open it is reasonable to consider having some workaround here, but it does sort of seem conceptually like something that should be handled by Avatica so I wonder if it would be easier and more proper to fix there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org