You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2026/09/26 17:38:03 UTC
[PR] [core] Check only index delta in StrictModeChecker partition overlap [paimon]
LuciferYang opened a new pull request, #10218:
URL: https://github.com/apache/paimon/pull/10218
### Purpose
`StrictModeChecker.hasOverlappedIndexPartition` read the whole cumulative index manifest of each checked snapshot, so it flagged a partition as overlapping even when that partition's index entries were merely inherited from earlier snapshots and were not touched by that snapshot's commit. Under strict mode a DV-only OVERWRITE by another user in one partition could therefore abort an unrelated commit in a different partition.
This aligns the index check with the data check, which only reads the snapshot's delta: it diffs the snapshot's index manifest against the previous snapshot's and considers only entries the commit added or replaced. The manifest-name fast exit is kept.
### Tests
Added `testStrictModeIgnoresInheritedIndexPartitions` in `TableCommitTest`: a DV-only OVERWRITE in pt=2 whose index manifest still carries pt=1's inherited DV entry does not abort a concurrent commit compacting pt=1, while a later OVERWRITE that actually replaces pt=1's DV entry still aborts that commit.
### API and Format
No.
### Documentation
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Do not count inherited index entries in the strict-mode partition check [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #10218:
URL: https://github.com/apache/paimon/pull/10218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Do not count inherited index entries in the strict-mode partition check [paimon]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #10218:
URL: https://github.com/apache/paimon/pull/10218#issuecomment-5949950755
@JingsongLi Could you help review this one: with deletion vectors, a rescale fails strict mode whenever another partition's compaction lands, the same kind of false positive as #8996. Details and a test that fails on master are in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Do not count inherited index entries in the strict-mode partition check [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #10218:
URL: https://github.com/apache/paimon/pull/10218#issuecomment-5996658115
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org