[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1287: MINIFICPP-1785 Fix CWEL attributes to be valid in HTTP requests

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #1287:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1287#discussion_r835765027



##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -712,8 +712,8 @@ void ConsumeWindowsEventLog::putEventRenderFlowFileToSession(const EventRender&
       session.write(flowFile, &wc);
     }
     session.putAttribute(flowFile, core::SpecialFlowAttribute::MIME_TYPE, mimeType);
-    session.putAttribute(flowFile, "Timezone name", timezone_name_);
-    session.putAttribute(flowFile, "Timezone offset", timezone_offset_);
+    session.putAttribute(flowFile, "timezone.name", timezone_name_);
+    session.putAttribute(flowFile, "timezone.offset", timezone_offset_);

Review comment:
       I thought the same at first, but then most other attributes have this format of dot separated lowercase words, so it's improving consistency anyway.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org