You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2017/09/04 07:35:43 UTC
[2/2] isis git commit: ISIS-1465: updates migration notes for 1.15.0
ISIS-1465: updates migration notes for 1.15.0
also fix javascript issue and markup issue
Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/fd0f8255
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/fd0f8255
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/fd0f8255
Branch: refs/heads/master
Commit: fd0f82557139c58975da0fb5324252f3877a0390
Parents: 1a9a40d
Author: Dan Haywood <da...@haywood-associates.co.uk>
Authored: Mon Aug 21 12:40:21 2017 +0100
Committer: Dan Haywood <da...@haywood-associates.co.uk>
Committed: Mon Sep 4 08:35:12 2017 +0100
----------------------------------------------------------------------
.../documentation/src/main/asciidoc/index.html | 2 --
.../main/asciidoc/js/toc-scroll/toc-scroll.js | 35 ++++++++++++--------
.../_migration-notes_1.14.0-to-1.15.0.adoc | 23 +++++++++++--
3 files changed, 42 insertions(+), 18 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/isis/blob/fd0f8255/adocs/documentation/src/main/asciidoc/index.html
----------------------------------------------------------------------
diff --git a/adocs/documentation/src/main/asciidoc/index.html b/adocs/documentation/src/main/asciidoc/index.html
index 813fb15..815a257 100644
--- a/adocs/documentation/src/main/asciidoc/index.html
+++ b/adocs/documentation/src/main/asciidoc/index.html
@@ -205,8 +205,6 @@ table.CodeRay td.code>pre{padding:0}
<li><a href="release-notes/release-notes.html">Release Notes</a></li>
<li><a href="migration-notes/migration-notes.html">Migration Notes</a></li>
<li role="separator" class="divider"></li>
-
- <li role="separator" class="divider"></li>
<li class="dropdown-header">Maven archetypes</li>
<li><a href="guides/ugfun/ugfun.html#_ugfun_getting-started_helloworld-archetype">helloworld</a></li>
<li><a href="guides/ugfun/ugfun.html#_ugfun_getting-started_simpleapp-archetype">simpleapp</a></li>
http://git-wip-us.apache.org/repos/asf/isis/blob/fd0f8255/adocs/documentation/src/main/asciidoc/js/toc-scroll/toc-scroll.js
----------------------------------------------------------------------
diff --git a/adocs/documentation/src/main/asciidoc/js/toc-scroll/toc-scroll.js b/adocs/documentation/src/main/asciidoc/js/toc-scroll/toc-scroll.js
index 537e230..462a8f8 100644
--- a/adocs/documentation/src/main/asciidoc/js/toc-scroll/toc-scroll.js
+++ b/adocs/documentation/src/main/asciidoc/js/toc-scroll/toc-scroll.js
@@ -2,22 +2,29 @@ $( document ).ready(function() {
$("ul.nav li a").click(function (event) {
var $target = $(event.currentTarget),
- $scrollToTarget = $($target.attr("href")),
- $header = $("nav.navbar-static-top"),
- prop = {
- // subtracting the offset results in the incorrect entry in the TOC from being highlighted.
- // since the sticky-header keeps the header out of the way, this isn't a problem for us.
- scrollTop: $scrollToTarget.offset().top /*- $header.outerHeight(true)*/
- },
- speed = 500;
+ targetHref = $target.attr("href");
+ if(targetHref && targetHref.startsWith("#")) {
+ var $scrollToTarget = $(targetHref),
+ $header = $("nav.navbar-static-top");
- $($header).attr("data-toc-scrolling", "true")
- $('html, body').animate(prop, speed,
- function() {
- var x = 2;
- $($header).removeAttr("data-toc-scrolling")
- });
+ if($scrollToTarget && $scrollToTarget.offset() && $scrollToTarget.offset().top) {
+ var prop = {
+ // subtracting the offset results in the incorrect entry in the TOC from being highlighted.
+ // since the sticky-header keeps the header out of the way, this isn't a problem for us.
+ scrollTop: $scrollToTarget.offset().top
+ },
+ speed = 500;
+
+
+ $($header).attr("data-toc-scrolling", "true")
+ $('html, body').animate(prop, speed,
+ function() {
+ var x = 2;
+ $($header).removeAttr("data-toc-scrolling")
+ });
+ }
+ }
});
});
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/isis/blob/fd0f8255/adocs/documentation/src/main/asciidoc/migration-notes/_migration-notes_1.14.0-to-1.15.0.adoc
----------------------------------------------------------------------
diff --git a/adocs/documentation/src/main/asciidoc/migration-notes/_migration-notes_1.14.0-to-1.15.0.adoc b/adocs/documentation/src/main/asciidoc/migration-notes/_migration-notes_1.14.0-to-1.15.0.adoc
index 10bae3a..b7e5201 100644
--- a/adocs/documentation/src/main/asciidoc/migration-notes/_migration-notes_1.14.0-to-1.15.0.adoc
+++ b/adocs/documentation/src/main/asciidoc/migration-notes/_migration-notes_1.14.0-to-1.15.0.adoc
@@ -9,6 +9,7 @@
+[[_migration-notes_1.14.0-to-1.15.0_isis-mavendeps]]
== `isis-mavendeps` Aggregator POMs
To remove boilerplate in your application's `pom.xml`, three new maven "aggregator projects have been defined:
@@ -29,7 +30,7 @@ This is defined in a profile which is actived only when running under the Intell
The xref:../ugfun/ugfun.adoc#_ugfun_getting-started_helloworld-archetype[HelloWorld] and xref:../ugfun/ugfun.adoc#_ugfun_getting-started_simpleapp-archetype[SimpleApp] archetypes both make use of these new aggregators.
-
+[[_migration-notes_1.14.0-to-1.15.0_ISIS-1528]]
== Rename of isis-viewer-wicket artifacts (link:https://issues.apache.org/jira/browse/ISIS-1528[ISIS-1528])
The `<groupId>` and `<artifactId>` of the xref:../guides/ugvw/ugvw.adoc#[Wicket viewer] have been made consistent with other artifacts:
@@ -55,6 +56,7 @@ has been renamed to:
----
+[[_migration-notes_1.14.0-to-1.15.0_ISIS-1611]]
== Overriding framework services (link:https://issues.apache.org/jira/browse/ISIS-1611[ISIS-1611])
Domain services fall into three categories:
@@ -73,7 +75,7 @@ Of course, your application can still override `menuOrder` if it wishes.
A small change (made in (link:https://issues.apache.org/jira/browse/ISIS-1688[ISIS-1688]) is that if both are set, then the minimum value is used.
-
+[[_migration-notes_1.14.0-to-1.15.0_ISIS-1504]]
== Metamodel validators (link:https://issues.apache.org/jira/browse/ISIS-1504[ISIS-1504], link:https://issues.apache.org/jira/browse/ISIS-1622[ISIS-1622], link:https://issues.apache.org/jira/browse/ISIS-1669[ISIS-1669])
The metamodel validator has been extended with several new checks relating to xref:../ugfun.adoc#_ugfun_programming-model_view-models_jaxb[JAXB view models]:
@@ -90,6 +92,7 @@ The metamodel validator has been extended with several new checks relating to xr
These checks are enabled by default but can be disabled with a xref:../rgcfg.adoc#__rgcfg_configuring-core_metamodel-validation[configuration property] if required.
+[[_migration-notes_1.14.0-to-1.15.0_ISIS-1613]]
== Logging workaround (link:https://issues.apache.org/jira/browse/ISIS-1613[ISIS-1613])
`ISIS-1613` improves the UI so that the framework does not repaint the entire page after a property edit or after invoking an action that returns the same object (`this`).
@@ -107,6 +110,7 @@ log4j.additivity.org.apache.wicket.page.XmlPartialPageUpdate=false
----
+[[_migration-notes_1.14.0-to-1.15.0_ISIS-1686]]
== Less boilerplate when bootstrapping (link:https://issues.apache.org/jira/browse/ISIS-1686[ISIS-1686]
Bootstrapping the application can now be accomplished with less boilerplate, both for the regular webapp and in integration tests.
@@ -115,6 +119,19 @@ For more information, see the xref:../ugtst/ugtst.adoc#_ugtst_integ-test-support
+[[_migration-notes_1.14.0-to-1.15.0_ISIS-1630]]
+== Fix for view models optionality (link:https://issues.apache.org/jira/browse/ISIS-1630[ISIS-1630]
+
+This ticket fixed a bug whereby - in the absence of an explicit `@Property(optionality=...)` or `@Nullable` annotation, a view model's properties would be defaulted as optional rather than mandatory.
+
+Note also that this bug fix means that numeric properties (eg `java.lang.Integer` and `java.lang.BigDecimal`) will default to zero if the view model is instantiated using `FactoryService#instantiate(...)`, and dates (eg `java.util.Date` and `org.jodatime.LocalDate`) will default to the current date.
+This could cause your application to behave differently.
+
+You should therefore inspect all properties of your view models and ensure that they are annotated as optional if required.
+
+
+
+[[_migration-notes_1.14.0-to-1.15.0_ISIS-1595]]
== Fix to config variable (link:https://issues.apache.org/jira/browse/ISIS-1595[ISIS-1595])
The configuration property xref:../guides/rgcfg/rgcfg.adoc#__rgcfg_configuring-core_metamodel-validation[] `isis.reflector.validator.jdoqlVariablesClause` was incorrectly named `variablesClause`.
@@ -123,6 +140,7 @@ This has now been corrected.
Any applications that used this configuration property should be updated.
+[[_migration-notes_1.14.0-to-1.15.0_ISIS-1690]]
== `@PostConstruct` always called (link:https://issues.apache.org/jira/browse/ISIS-1690[ISIS-1690])
In previous versions, if any domain service threw an exception in their initialization method (annotated `@PostConstruct`) then none of the remaining domain services would be initialized.
@@ -133,6 +151,7 @@ The first exception encountered is then re-thrown (to preserve similar behaviour
+[[_migration-notes_1.14.0-to-1.15.0_incode-platform]]
== (non-ASF) Incode Platform
(*work in progress*) The supporting (non-ASF) link:http://isisaddons.org[Isis Addons] and link:http://catalog.incode.org[Incode Catalog] have also been reorganised into a single link:http://platform.incode.org["Incode Platform"].