You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/23 08:54:25 UTC

[GitHub] [pulsar-client-go] shohi opened a new issue #296: is there a way to know whether ack/nack succeeds or fails

shohi opened a new issue #296:
URL: https://github.com/apache/pulsar-client-go/issues/296


   From the source code, no callback or returned error is found.
   
   ```go
   type Consumer interface {
           // Ack the consumption of a single message
   	Ack(Message)
          
           // Acknowledge the failure to process a single message.
   	//
   	// When a message is "negatively acked" it will be marked for redelivery after
   	// some fixed delay. The delay is configurable when constructing the consumer
   	// with ConsumerOptions.NAckRedeliveryDelay .
   	//
   	// This call is not blocking.
   	Nack(Message)
   
          // ...
   }
   
   
   
   
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-client-go] sijie commented on issue #296: is there a way to know whether ack/nack succeeds or fails

Posted by GitBox <gi...@apache.org>.
sijie commented on issue #296:
URL: https://github.com/apache/pulsar-client-go/issues/296#issuecomment-648530927


   @shohi Currently the protocol of acknowledge doesn't support any response. It is fire-and-forget. We will add responses for acknowledgment as part of transaction support. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-client-go] shohi edited a comment on issue #296: is there a way to know whether ack/nack succeeds or fails

Posted by GitBox <gi...@apache.org>.
shohi edited a comment on issue #296:
URL: https://github.com/apache/pulsar-client-go/issues/296#issuecomment-650673683


   Take a step back, is it possible for the library to support customized error handlers for failures of sending Ack/Nack request? 
   
   It will be even better that Ack/Nack could support timeout or context. There is a related issue of Ack timeout - https://github.com/apache/pulsar-client-go/issues/217, i think the ack timeout is helpful in some scenarios where the client only consumes one specific topic.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-client-go] shohi edited a comment on issue #296: is there a way to know whether ack/nack succeeds or fails

Posted by GitBox <gi...@apache.org>.
shohi edited a comment on issue #296:
URL: https://github.com/apache/pulsar-client-go/issues/296#issuecomment-650673683


   Take a step back, is it possible for the library to support customized error handlers for failures of sending Ack/Nack request? 
   
   And it will be even better that Ack/Nack could support timeout or context. There is a related issue of Ack timeout - https://github.com/apache/pulsar-client-go/issues/217, i think the ack timeout is helpful in some scenarios where the client only consumes one specific topic.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-client-go] shohi edited a comment on issue #296: is there a way to know whether ack/nack succeeds or fails

Posted by GitBox <gi...@apache.org>.
shohi edited a comment on issue #296:
URL: https://github.com/apache/pulsar-client-go/issues/296#issuecomment-650673683


   Take a step back, is it possible for the library to support customized error handlers for failures of sending Ack/Nack request as both of them are non-blocking? 
   
   <s>And it will be even better that Ack/Nack could support timeout or context. There is a related issue of Ack timeout - https://github.com/apache/pulsar-client-go/issues/217, i think the ack timeout is helpful in some scenarios where the client only consumes one specific topic.</s>
   
   see @merlimat's explanation on Ack timeout - https://github.com/apache/pulsar-client-go/issues/217#issuecomment-650674545
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-client-go] merlimat commented on issue #296: is there a way to know whether ack/nack succeeds or fails

Posted by GitBox <gi...@apache.org>.
merlimat commented on issue #296:
URL: https://github.com/apache/pulsar-client-go/issues/296#issuecomment-649743606


   > And I also wonder if it's possible to provide callback handlers for connection/operation errors, thus users can utilize them to do some logging or monitoring.
   
   The connection aspect are hidden by design, to provide higher-level API components only. The internal reconnections are already logged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-client-go] shohi commented on issue #296: is there a way to know whether ack/nack succeeds or fails

Posted by GitBox <gi...@apache.org>.
shohi commented on issue #296:
URL: https://github.com/apache/pulsar-client-go/issues/296#issuecomment-648671120


   @sijie thanks for your reply, glad to hear it will come along with transaction support. And I also wonder if it's possible to provide callback handlers for connection/operation errors, thus users can utilize them to do some logging or monitoring.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-client-go] shohi edited a comment on issue #296: is there a way to know whether ack/nack succeeds or fails

Posted by GitBox <gi...@apache.org>.
shohi edited a comment on issue #296:
URL: https://github.com/apache/pulsar-client-go/issues/296#issuecomment-650673683


   Take a step back, is it possible for the library to support customized error handlers for failures of sending Ack/Nack request as both of them are non-blocking? 
   
   And it will be even better that Ack/Nack could support timeout or context. There is a related issue of Ack timeout - https://github.com/apache/pulsar-client-go/issues/217, i think the ack timeout is helpful in some scenarios where the client only consumes one specific topic.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-client-go] shohi commented on issue #296: is there a way to know whether ack/nack succeeds or fails

Posted by GitBox <gi...@apache.org>.
shohi commented on issue #296:
URL: https://github.com/apache/pulsar-client-go/issues/296#issuecomment-649906343


   > > And I also wonder if it's possible to provide callback handlers for connection/operation errors, thus users can utilize them to do some logging or monitoring.
   > 
   > The connection aspect are hidden by design, to provide higher-level API components only. The internal reconnections are already logged.
   
   Yeah, but IMHO it's useful to notify users that exceptions/unrecoverable errors have occurred. In practice, we want to monitor the out connections and log key events with user-defined error/event codes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-client-go] shohi commented on issue #296: is there a way to know whether ack/nack succeeds or fails

Posted by GitBox <gi...@apache.org>.
shohi commented on issue #296:
URL: https://github.com/apache/pulsar-client-go/issues/296#issuecomment-650673683


   It will be even better that Ack/Nack could support timeout or context. There is a related issue of Ack timeout - https://github.com/apache/pulsar-client-go/issues/217, i think the ack timeout is helpful in some scenarios where the client only consumes one specific topic.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-client-go] shohi edited a comment on issue #296: is there a way to know whether ack/nack succeeds or fails

Posted by GitBox <gi...@apache.org>.
shohi edited a comment on issue #296:
URL: https://github.com/apache/pulsar-client-go/issues/296#issuecomment-650673683


   Take a step back, is it possible for the library to support customized error handlers for failures of sending Ack/Nack request as both of them are non-blocking? 
   
   <s>And it will be even better that Ack/Nack could support timeout or context. There is a related issue of Ack timeout - https://github.com/apache/pulsar-client-go/issues/217, i think the ack timeout is helpful in some scenarios where the client only consumes one specific topic.</s> (see @merlimat's explanation on Ack timeout - https://github.com/apache/pulsar-client-go/issues/217#issuecomment-650674545)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org