You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/24 05:02:17 UTC
[GitHub] marcoabreu commented on a change in pull request #12642: Enable C++
coverage
marcoabreu commented on a change in pull request #12642: Enable C++ coverage
URL: https://github.com/apache/incubator-mxnet/pull/12642#discussion_r219730306
##########
File path: Makefile
##########
@@ -92,6 +92,10 @@ endif
CFLAGS += -I$(TPARTYDIR)/mshadow/ -I$(TPARTYDIR)/dmlc-core/include -fPIC -I$(NNVM_PATH)/include -I$(DLPACK_PATH)/include -I$(TPARTYDIR)/tvm/include -Iinclude $(MSHADOW_CFLAGS)
LDFLAGS = -pthread $(MSHADOW_LDFLAGS) $(DMLC_LDFLAGS)
+ifeq ($(ENABLE_TESTCOVERAGE), 1)
+ CFLAGS += --coverage
+ LDFLAGS += --coverage
+endif
Review comment:
It's only compatible with GCC and clang, right. Want me to add a check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services