[GitHub] hughhhh commented on a change in pull request #6564: [design] use angle icons instead of carets for expandable panels

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #6564: [design] use angle icons instead of carets for expandable panels
URL: https://github.com/apache/incubator-superset/pull/6564#discussion_r243724995
 
 

 ##########
 File path: superset/assets/src/explore/components/ControlPanelSection.jsx
 ##########
 @@ -31,21 +31,21 @@ export default class ControlPanelSection extends React.Component {
     return (
       label &&
         <div>
+          <span>
+            <span onClick={this.toggleExpand.bind(this)}>{label}</span>
+            {' '}
 
 Review comment:
   do we need this still?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org