You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jose-torres <gi...@git.apache.org> on 2018/03/28 17:19:36 UTC

[GitHub] spark pull request #20921: Roll forward "[SPARK-23096][SS] Migrate rate sour...

GitHub user jose-torres opened a pull request:

    https://github.com/apache/spark/pull/20921

    Roll forward "[SPARK-23096][SS] Migrate rate source to V2"

    ## What changes were proposed in this pull request?
    
    Roll forward c68ec4e6a1ed9ea13345c7705ea60ff4df7aec7b (https://github.com/apache/spark/pull/20688)
    
    There are two minor test changes required:
    
    * An error which used to be TreeNodeException[ArithmeticException] is no longer wrapped and is now just ArithmeticException.
    * The test framework was not setting the active Spark session for some reason.
    
    ## How was this patch tested?
    
    existing unit tests


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jose-torres/spark fixbadtest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20921.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20921
    
----
commit c2e6c92cf42dfe869ca76a803cd3e8474f118120
Author: Jose Torres <to...@...>
Date:   2018-03-28T17:16:02Z

    fix test issues

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20921: Roll forward "[SPARK-23096][SS] Migrate rate source to V...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20921
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20921: Roll forward "[SPARK-23096][SS] Migrate rate source to V...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20921
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88668/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20921: Roll forward "[SPARK-23096][SS] Migrate rate sour...

Posted by jose-torres <gi...@git.apache.org>.
Github user jose-torres closed the pull request at:

    https://github.com/apache/spark/pull/20921


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20921: Roll forward "[SPARK-23096][SS] Migrate rate source to V...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20921
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20921: Roll forward "[SPARK-23096][SS] Migrate rate source to V...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20921
  
    **[Test build #88668 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88668/testReport)** for PR 20921 at commit [`c2e6c92`](https://github.com/apache/spark/commit/c2e6c92cf42dfe869ca76a803cd3e8474f118120).
     * This patch **fails to build**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `class RateSourceSuite extends StreamTest `
      * `  case class AdvanceRateManualClock(seconds: Long) extends AddData `


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20921: Roll forward "[SPARK-23096][SS] Migrate rate source to V...

Posted by jose-torres <gi...@git.apache.org>.
Github user jose-torres commented on the issue:

    https://github.com/apache/spark/pull/20921
  
    I rebased wrong. Let me fix the commit history.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20921: Roll forward "[SPARK-23096][SS] Migrate rate source to V...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20921
  
    **[Test build #88668 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88668/testReport)** for PR 20921 at commit [`c2e6c92`](https://github.com/apache/spark/commit/c2e6c92cf42dfe869ca76a803cd3e8474f118120).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org