You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "onebox-li (via GitHub)" <gi...@apache.org> on 2023/08/10 10:08:05 UTC

[GitHub] [incubator-celeborn] onebox-li opened a new pull request, #1805: [CELEBORN-887] Improve celeborn-daemon.sh script

onebox-li opened a new pull request, #1805:
URL: https://github.com/apache/incubator-celeborn/pull/1805

   ### What changes were proposed in this pull request?
   I find a little difficult to use `celeborn-daemon.sh` to get instance status, so I polish the usage and fix --config load.
   
   
   ### Why are the changes needed?
   Ditto
   
   
   ### Does this PR introduce _any_ user-facing change?
   Polish the `celeborn-daemon.sh` usage 
   
   
   ### How was this patch tested?
   Manually test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1805: [CELEBORN-887] Option --config should take effect in celeborn-daemon.sh script

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1805:
URL: https://github.com/apache/incubator-celeborn/pull/1805#issuecomment-1674837475

   Thanks, merging to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1805: [CELEBORN-887] Improve celeborn-daemon.sh script

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1805:
URL: https://github.com/apache/incubator-celeborn/pull/1805#issuecomment-1672953759

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1805?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#1805](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1805?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cabfd53) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/3ec218878afc2285015405b9f7332dbe0afd694b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3ec2188) will **decrease** coverage by `0.15%`.
   > Report is 1 commits behind head on main.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head cabfd53 differs from pull request most recent head 3018f1f. Consider uploading reports for the commit 3018f1f to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #1805      +/-   ##
   ==========================================
   - Coverage   46.75%   46.59%   -0.15%     
   ==========================================
     Files         162      162              
     Lines       10077    10077              
     Branches      927      927              
   ==========================================
   - Hits         4710     4694      -16     
   - Misses       5059     5072      +13     
   - Partials      308      311       +3     
   ```
   
   
   [see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1805/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1805: [CELEBORN-887] Option --config should take effect in celeborn-daemon.sh script

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1805:
URL: https://github.com/apache/incubator-celeborn/pull/1805#discussion_r1290216044


##########
sbin/celeborn-daemon.sh:
##########
@@ -28,20 +28,23 @@
 #   CELEBORN_NO_DAEMONIZE   If set, will run the proposed command in the foreground. It will not output a PID file.
 ##
 
-usage="Usage: celeborn-daemon.sh [--config <conf-dir>] (start|stop|status) <celeborn-command> <celeborn-instance-number> <args...>"
+usage() {
+  echo "Usage: celeborn-daemon.sh [--config <conf-dir>] (start|stop|restart|status) <celeborn-class-name> <celeborn-instance-number> [args]"
+  echo ""
+  echo "OPTIONS"

Review Comment:
   ```suggestion
     echo "Options:"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture closed pull request #1805: [CELEBORN-887] Option --config should take effect in celeborn-daemon.sh script

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1805: [CELEBORN-887] Option --config should take effect in celeborn-daemon.sh script
URL: https://github.com/apache/incubator-celeborn/pull/1805


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1805: [CELEBORN-887] Option --config should take effect in celeborn-daemon.sh script

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1805:
URL: https://github.com/apache/incubator-celeborn/pull/1805#discussion_r1290213104


##########
sbin/celeborn-daemon.sh:
##########
@@ -28,20 +28,22 @@
 #   CELEBORN_NO_DAEMONIZE   If set, will run the proposed command in the foreground. It will not output a PID file.
 ##
 
-usage="Usage: celeborn-daemon.sh [--config <conf-dir>] (start|stop|status) <celeborn-command> <celeborn-instance-number> <args...>"
+usage() {
+  echo "Usage: celeborn-daemon.sh [--config <conf-dir>] (start|stop|restart|status) <celeborn-class-name> <celeborn-instance-number> [args]"
+  echo "Definitions:"
+  echo "  <conf-dir>                  Override CELEBORN_CONF_DIR"
+  echo "  <celeborn-class-name>       The class name of the celeborn command to run"

Review Comment:
   ```suggestion
     echo "  <celeborn-class-name>       The main class name of the celeborn command to run"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1805: [CELEBORN-887] Option --config should take effect in celeborn-daemon.sh script

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1805:
URL: https://github.com/apache/incubator-celeborn/pull/1805#discussion_r1290215226


##########
sbin/celeborn-daemon.sh:
##########
@@ -28,20 +28,22 @@
 #   CELEBORN_NO_DAEMONIZE   If set, will run the proposed command in the foreground. It will not output a PID file.
 ##
 
-usage="Usage: celeborn-daemon.sh [--config <conf-dir>] (start|stop|status) <celeborn-command> <celeborn-instance-number> <args...>"
+usage() {
+  echo "Usage: celeborn-daemon.sh [--config <conf-dir>] (start|stop|restart|status) <celeborn-class-name> <celeborn-instance-number> [args]"
+  echo "Definitions:"

Review Comment:
   ```suggestion
     echo ""
     echo "OPTIONS"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org