You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/30 22:58:04 UTC
[GitHub] [flink-kubernetes-operator] tedhtchang opened a new pull request, #458: [FLINK-27852] Add OLM bundle generator
tedhtchang opened a new pull request, #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458
Signed-off-by: ted chang <ht...@us.ibm.com>
## What is the purpose of the change
This pull request adds scripts to generate OLM bundle from the helm chart.
## Brief change log
- Add scripts to generate and test the OLM bundle.
- Document the scripts and OLM bundle CI tests.
## Verifying this change
The AutomatedOLMBuildAndDeploy.sh script will generate the bundle and deploy the Flink Kubernetes Operator locally.
## Does this pull request potentially affect one of the following parts:
No
## Documentation
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1334479821
cc @gaborgsomogyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1340043594
> @morhidi How about this? `head -c24 < /dev/random|base64|tr -dc "[:lower:]"|head -c24`
lik in the good old days :) I guess we can ignore the percentage character which is a zsh 'thing'
````
(minikube:default) ➜ olm git:(FLINK-27852) head -c24 < /dev/random|base64|tr -dc "[:lower:]"|head -c24
pwhtwbmibjwmd%
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1336323496
We should add the generated folders to .gitignore:
```
1.3.0/
cat/
crds/
helm/
```
Maybe it's even better to put these behind a single `generated` or `target` or sg similar folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tedhtchang commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
tedhtchang commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1340085056
@morhidi It should be fine. `%` means output has no trailing new line. ie. `echo -n hello`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi merged pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
morhidi merged PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tedhtchang commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
tedhtchang commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1332870362
@morhidi @gyfora
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tedhtchang commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
tedhtchang commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1335624431
Hi @morhidi thanks for review! Which base image would you recommend ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1335617227
Thanks @tedhtchang for the PR. I checked and it seems the scripts are not platform independent unfortunately. We cannot use them:/ We should probably aim to build a docker image out of it that can run on various host machines (including mac os with m1). We could probably provide a Dockerfile that builds a local image out of these scripts and use it to generate the bundle, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tedhtchang commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
tedhtchang commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1338582538
Hi @morhidi Could you test on a m1 mac again. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1336323557
> Hi @morhidi I can't find a mac os w/ m1 right now. If you have one could you run the new ./generate-olm-bundle.sh script and see if this what we want?
It works on m1 thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tedhtchang commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
tedhtchang commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1340023237
@morhidi How about this? `head -c24 < /dev/random|base64|tr -dc "[:lower:]"|head -c24`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1340009137
> > > Hi @morhidi Could you test on a m1 mac again. Thanks.
> >
> >
> > will do thanks!
>
> I'm now getting on mac os with zsh:
>
> ```
> (minikube:default) ➜ olm git:(FLINK-27852) ./generate-olm-bundle.sh
> tr: Illegal byte sequence
> (minikube:default) ➜ olm git:(FLINK-27852) source env.sh
> tr: Illegal byte sequence
> ```
Try using something like this:
```
(minikube:default) ➜ olm git:(FLINK-27852) head -c24 < /dev/random | base64
ATgq7rlRefHs+pPE4twDn0XmDctHhU4o
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1336322881
Hi @tedhtchang this looks better now however I guess this was unintentional:
```
+ docker push docker.io/tedhtchang/flink-op-bundle:1.3.0
The push refers to repository [docker.io/tedhtchang/flink-op-bundle]
893500a83403: Preparing
ba0bcc7ff5c8: Preparing
denied: requested access to the resource is denied
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tedhtchang commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
tedhtchang commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1340270812
@morhidi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1335943207
Please also rebase to the latest main version, e2es has been fixed recently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1335706012
> Hi @morhidi thanks for review! Which base image would you recommend ?
I've no preference, use whatever you feel is the best fit for these scripts to run properly. Please make sure though that the base image is multi arch and contains `arm64` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tedhtchang commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
tedhtchang commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1336310902
Hi @morhidi I can't find a mac os w/ m1 right now. If you have one could you run the new ./generate-olm-bundle.sh script and see if this what we want?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1340009650
> > > > Hi @morhidi Could you test on a m1 mac again. Thanks.
> > >
> > >
> > > will do thanks!
> >
> >
> > I'm now getting on mac os with zsh:
> > ```
> > (minikube:default) ➜ olm git:(FLINK-27852) ./generate-olm-bundle.sh
> > tr: Illegal byte sequence
> > (minikube:default) ➜ olm git:(FLINK-27852) source env.sh
> > tr: Illegal byte sequence
> > ```
>
> Try using something like this:
>
> ```
> (minikube:default) ➜ olm git:(FLINK-27852) head -c24 < /dev/random | base64
> ATgq7rlRefHs+pPE4twDn0XmDctHhU4o
> ```
rc: https://unix.stackexchange.com/questions/45404/why-cant-tr-read-from-dev-urandom-on-osx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1339932313
> > Hi @morhidi Could you test on a m1 mac again. Thanks.
>
> will do thanks!
I'm now getting on mac os with zsh:
```
(minikube:default) ➜ olm git:(FLINK-27852) ./generate-olm-bundle.sh
tr: Illegal byte sequence
(minikube:default) ➜ olm git:(FLINK-27852) source env.sh
tr: Illegal byte sequence
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #458: [FLINK-27852] Add OLM bundle generator
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #458:
URL: https://github.com/apache/flink-kubernetes-operator/pull/458#issuecomment-1339926077
> Hi @morhidi Could you test on a m1 mac again. Thanks.
will do thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org