[GitHub] iilyak commented on a change in pull request #1085: Return update_seq and offset when update_seq is true and keys is set

[GitBox <gi...@apache.org>]

iilyak commented on a change in pull request #1085: Return update_seq and offset when update_seq is true and keys is set
URL: https://github.com/apache/couchdb/pull/1085#discussion_r161293340
 
 

 ##########
 File path: src/fabric/src/fabric_view_all_docs.erl
 ##########
 @@ -59,7 +59,8 @@ go(DbName, Options, QueryArgs, Callback, Acc0) ->
         conflicts = Conflicts,
         skip = Skip,
         keys = Keys0,
-        extra = Extra
+        extra = Extra,
+        update_seq = UpdateSeq
 
 Review comment:
   We should split the update of the record into two commits. 
   1. add compatibility clause so with this commit we would be able to handle both kinds of records. This commit would convert new record to old one.
   2. add new field and change conversion clause so it converts the old one into new.
   
   The reason for the split is handling of mixed cluster case when some nodes are upgraded and some of them don't. 
   
   This would allow us to do two stage upgrade of the cluster. First we would deploy version with first commit to all nodes. Then we wait a little bit and deploy the version with second commit.
   
   This dance is usually needed for the cases when we upgrade records we send to other nodes. Which is the case for `#mrargs{}` .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services