You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/31 10:06:27 UTC
[GitHub] [arrow] jorgecarleitao opened a new pull request #9056: ARROW-11085: [Rust] Migrated from action-rs to shell in github actions.
jorgecarleitao opened a new pull request #9056:
URL: https://github.com/apache/arrow/pull/9056
This addresses a blocker in our pipeline causing all CIs to not run due to a policy change by the INFRA team.
See https://issues.apache.org/jira/browse/INFRA-21234 and https://issues.apache.org/jira/browse/INFRA-21239 for more details.
There is still a blocker for macos and windows, which use non-official cache action that I do not know how to reproduce in shell, but at least we get all our tests, fmt and clippy back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #9056: ARROW-11085: [Rust] Migrated from action-rs to shell in github actions.
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9056:
URL: https://github.com/apache/arrow/pull/9056#issuecomment-752913368
cc @nevi-me @nealrichardson @alamb @andygrove ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9056: ARROW-11085: [Rust] Migrated from action-rs to shell in github actions.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9056:
URL: https://github.com/apache/arrow/pull/9056#issuecomment-752912210
https://issues.apache.org/jira/browse/ARROW-11085
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #9056: ARROW-11085: [Rust] Migrated from action-rs to shell in github actions.
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #9056:
URL: https://github.com/apache/arrow/pull/9056#discussion_r550479241
##########
File path: .github/workflows/rust.yml
##########
@@ -57,11 +57,11 @@ jobs:
# and thus are specific for a particular OS, arch and rust version.
path: /github/home/target
key: ${{ runner.os }}-${{ matrix.arch }}-target-cache-${{ matrix.rust }}-
- - uses: actions-rs/toolchain@v1
- with:
- toolchain: ${{ matrix.rust }}
- default: true
- components: rustfmt
+ - name: Setup Rust toolchain
+ run: |
Review comment:
π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9056: ARROW-11085: [Rust] Migrated from action-rs to shell in github actions.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9056:
URL: https://github.com/apache/arrow/pull/9056#issuecomment-752917431
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9056?src=pr&el=h1) Report
> Merging [#9056](https://codecov.io/gh/apache/arrow/pull/9056?src=pr&el=desc) (23c6003) into [master](https://codecov.io/gh/apache/arrow/commit/2f6874158e3d94bd5eb31765c2550dce8d015c19?el=desc) (2f68741) will **decrease** coverage by `0.23%`.
> The diff coverage is `68.27%`.
[](https://codecov.io/gh/apache/arrow/pull/9056?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9056 +/- ##
==========================================
- Coverage 82.87% 82.64% -0.24%
==========================================
Files 201 202 +1
Lines 49737 50044 +307
==========================================
+ Hits 41219 41357 +138
- Misses 8518 8687 +169
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9056?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [rust/arrow/src/array/equal/mod.rs](https://codecov.io/gh/apache/arrow/pull/9056/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvbW9kLnJz) | `91.94% <ΓΈ> (ΓΈ)` | |
| [rust/arrow/src/compute/kernels/take.rs](https://codecov.io/gh/apache/arrow/pull/9056/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3Rha2UucnM=) | `95.21% <ΓΈ> (-0.04%)` | :arrow_down: |
| [rust/arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow/pull/9056/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS91dGlsLnJz) | `98.93% <ΓΈ> (ΓΈ)` | |
| [rust/arrow/src/json/reader.rs](https://codecov.io/gh/apache/arrow/pull/9056/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvanNvbi9yZWFkZXIucnM=) | `81.49% <ΓΈ> (ΓΈ)` | |
| [rust/arrow/src/util/test\_util.rs](https://codecov.io/gh/apache/arrow/pull/9056/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvdXRpbC90ZXN0X3V0aWwucnM=) | `90.90% <ΓΈ> (ΓΈ)` | |
| [rust/datafusion/examples/flight\_server.rs](https://codecov.io/gh/apache/arrow/pull/9056/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL2V4YW1wbGVzL2ZsaWdodF9zZXJ2ZXIucnM=) | `0.00% <0.00%> (ΓΈ)` | |
| [rust/datafusion/src/datasource/csv.rs](https://codecov.io/gh/apache/arrow/pull/9056/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2Nzdi5ycw==) | `81.25% <ΓΈ> (ΓΈ)` | |
| [rust/datafusion/src/datasource/datasource.rs](https://codecov.io/gh/apache/arrow/pull/9056/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2RhdGFzb3VyY2UucnM=) | `100.00% <ΓΈ> (ΓΈ)` | |
| [rust/datafusion/src/datasource/empty.rs](https://codecov.io/gh/apache/arrow/pull/9056/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2VtcHR5LnJz) | `70.58% <ΓΈ> (ΓΈ)` | |
| [rust/datafusion/src/logical\_plan/builder.rs](https://codecov.io/gh/apache/arrow/pull/9056/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vYnVpbGRlci5ycw==) | `88.26% <0.00%> (ΓΈ)` | |
| ... and [47 more](https://codecov.io/gh/apache/arrow/pull/9056/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9056?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9056?src=pr&el=footer). Last update [2440c9e...23c6003](https://codecov.io/gh/apache/arrow/pull/9056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9056: ARROW-11085: [Rust] Migrated from action-rs to shell in github actions.
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9056:
URL: https://github.com/apache/arrow/pull/9056
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org