You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Martin Ritchie <ri...@apache.org> on 2010/01/13 17:08:03 UTC
[0.6] Patch request for inclusion
Hi Andrew,
I've been looking at some of the Java test failures and have found an
issue (QPID-2137) that I would really like to be included in 0.6.
I think this is deserving of blocking startus and therefore inclusion
as without this patch the status logging feature cannot be used as it
will likely cause a failure of the broker.
The patch is to create a new MessageFormater for every log message
rather than reusing a static formatter. I have committed the change
to trunk already but I'd appreciate it if we can include it for 0.6.
Regards
Martin
--
Martin Ritchie
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [0.6] Patch request for inclusion
Posted by Gordon Sim <gs...@redhat.com>.
On 01/25/2010 05:40 PM, Carl Trieloff wrote:
>
> I thought it was, Gordon, has that been committed to the branch?
No I don't believe it has (I certainly never merged it across).
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [0.6] Patch request for inclusion
Posted by Carl Trieloff <cc...@redhat.com>.
I thought it was, Gordon, has that been committed to the branch?
Carl.
On 01/25/2010 12:29 PM, Robbie Gemmell wrote:
>
> The hazards of bumps on the tracks while using ones phone on the train
> ;-)
>
> Was it decided that the use of an LVQ leading to crashing the C++
> broker wasnt an a blocker? That fix didn't make RC3 iirc?
>
> Robbie.
>
>
> On 25 Jan 2010, at 17:19, Robbie Gemmell <ro...@gmail.com>
> wrote:
>
>>
>>
>>
>>
>> On 25 Jan 2010, at 16:29, Andrew Stitcher <as...@redhat.com> wrote:
>>
>>> On Wed, 2010-01-13 at 11:08 -0500, Martin Ritchie wrote:
>>>> Hi Andrew,
>>>>
>>>> I've been looking at some of the Java test failures and have found an
>>>> issue (QPID-2137) that I would really like to be included in 0.6.
>>>>
>>>> I think this is deserving of blocking startus and therefore inclusion
>>>> as without this patch the status logging feature cannot be used as it
>>>> will likely cause a failure of the broker.
>>>>
>>>> The patch is to create a new MessageFormater for every log message
>>>> rather than reusing a static formatter. I have committed the change
>>>> to trunk already but I'd appreciate it if we can include it for 0.6.
>>>
>>> I'm not clear from this email or the jira itself if this fits the
>>> criteria for blocker :-
>>>
>>> 1. Regression from 0.5 release behaviour. AND
>>> 2. Serious problem which will stop a user being able to use the broker.
>>>
>>> Martin
>>>
>>> If you think that it does satisfy both of these then please assign the
>>> bug back to you and commit the patch to the branch. Then let me know -
>>> I'll issue a new RC, and a call to vote.
>>>
>>> If on reflection you don't think it meets both of these criteria then
>>> I'll issue a call for vote on the existing RC.
>>>
>>> Andrew
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> Apache Qpid - AMQP Messaging Implementation
>>> Project: http://qpid.apache.org
>>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>>>
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [0.6] Patch request for inclusion
Posted by Gordon Sim <gs...@redhat.com>.
On 01/25/2010 06:35 PM, Gordon Sim wrote:
> On 01/25/2010 06:12 PM, Andrew Stitcher wrote:
>> On Mon, 2010-01-25 at 17:29 +0000, Robbie Gemmell wrote:
>>> The hazards of bumps on the tracks while using ones phone on the
>>> train ;-)
>>>
>>> Was it decided that the use of an LVQ leading to crashing the C++
>>> broker wasnt an a blocker? That fix didn't make RC3 iirc?
>>
>> I don't think it was raised as a blocker and Gordon didn't raise it to
>> one as a result of my prodding.
>>
>> I was (and am) entirely open to the idea that is a blocker for the
>> current RC.
>
> From the log it was committed to trunk as r896687, I am happy to merge
> that across to your release branch if you like.
I have now done this, reopened the BZ and marked it a blocker.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [0.6] Patch request for inclusion
Posted by Gordon Sim <gs...@redhat.com>.
On 01/25/2010 06:12 PM, Andrew Stitcher wrote:
> On Mon, 2010-01-25 at 17:29 +0000, Robbie Gemmell wrote:
>> The hazards of bumps on the tracks while using ones phone on the
>> train ;-)
>>
>> Was it decided that the use of an LVQ leading to crashing the C++
>> broker wasnt an a blocker? That fix didn't make RC3 iirc?
>
> I don't think it was raised as a blocker and Gordon didn't raise it to
> one as a result of my prodding.
>
> I was (and am) entirely open to the idea that is a blocker for the
> current RC.
From the log it was committed to trunk as r896687, I am happy to merge
that across to your release branch if you like.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [0.6] Patch request for inclusion
Posted by Andrew Stitcher <as...@redhat.com>.
On Mon, 2010-01-25 at 17:29 +0000, Robbie Gemmell wrote:
> The hazards of bumps on the tracks while using ones phone on the
> train ;-)
>
> Was it decided that the use of an LVQ leading to crashing the C++
> broker wasnt an a blocker? That fix didn't make RC3 iirc?
I don't think it was raised as a blocker and Gordon didn't raise it to
one as a result of my prodding.
I was (and am) entirely open to the idea that is a blocker for the
current RC.
Andrew
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [0.6] Patch request for inclusion
Posted by Robbie Gemmell <ro...@gmail.com>.
The hazards of bumps on the tracks while using ones phone on the
train ;-)
Was it decided that the use of an LVQ leading to crashing the C++
broker wasnt an a blocker? That fix didn't make RC3 iirc?
Robbie.
On 25 Jan 2010, at 17:19, Robbie Gemmell <ro...@gmail.com>
wrote:
>
>
>
>
> On 25 Jan 2010, at 16:29, Andrew Stitcher <as...@redhat.com>
> wrote:
>
>> On Wed, 2010-01-13 at 11:08 -0500, Martin Ritchie wrote:
>>> Hi Andrew,
>>>
>>> I've been looking at some of the Java test failures and have found
>>> an
>>> issue (QPID-2137) that I would really like to be included in 0.6.
>>>
>>> I think this is deserving of blocking startus and therefore
>>> inclusion
>>> as without this patch the status logging feature cannot be used as
>>> it
>>> will likely cause a failure of the broker.
>>>
>>> The patch is to create a new MessageFormater for every log message
>>> rather than reusing a static formatter. I have committed the change
>>> to trunk already but I'd appreciate it if we can include it for 0.6.
>>
>> I'm not clear from this email or the jira itself if this fits the
>> criteria for blocker :-
>>
>> 1. Regression from 0.5 release behaviour. AND
>> 2. Serious problem which will stop a user being able to use the
>> broker.
>>
>> Martin
>>
>> If you think that it does satisfy both of these then please assign
>> the
>> bug back to you and commit the patch to the branch. Then let me
>> know -
>> I'll issue a new RC, and a call to vote.
>>
>> If on reflection you don't think it meets both of these criteria then
>> I'll issue a call for vote on the existing RC.
>>
>> Andrew
>>
>>
>>
>> ---------------------------------------------------------------------
>> Apache Qpid - AMQP Messaging Implementation
>> Project: http://qpid.apache.org
>> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>>
Re: [0.6] Patch request for inclusion
Posted by Robbie Gemmell <ro...@gmail.com>.
On 25 Jan 2010, at 16:29, Andrew Stitcher <as...@redhat.com> wrote:
> On Wed, 2010-01-13 at 11:08 -0500, Martin Ritchie wrote:
>> Hi Andrew,
>>
>> I've been looking at some of the Java test failures and have found an
>> issue (QPID-2137) that I would really like to be included in 0.6.
>>
>> I think this is deserving of blocking startus and therefore inclusion
>> as without this patch the status logging feature cannot be used as it
>> will likely cause a failure of the broker.
>>
>> The patch is to create a new MessageFormater for every log message
>> rather than reusing a static formatter. I have committed the change
>> to trunk already but I'd appreciate it if we can include it for 0.6.
>
> I'm not clear from this email or the jira itself if this fits the
> criteria for blocker :-
>
> 1. Regression from 0.5 release behaviour. AND
> 2. Serious problem which will stop a user being able to use the
> broker.
>
> Martin
>
> If you think that it does satisfy both of these then please assign the
> bug back to you and commit the patch to the branch. Then let me know -
> I'll issue a new RC, and a call to vote.
>
> If on reflection you don't think it meets both of these criteria then
> I'll issue a call for vote on the existing RC.
>
> Andrew
>
>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [0.6] Patch request for inclusion
Posted by Martin Ritchie <ri...@apache.org>.
2010/1/25 Andrew Stitcher <as...@redhat.com>:
> On Wed, 2010-01-13 at 11:08 -0500, Martin Ritchie wrote:
>> Hi Andrew,
>>
>> I've been looking at some of the Java test failures and have found an
>> issue (QPID-2137) that I would really like to be included in 0.6.
>>
>> I think this is deserving of blocking startus and therefore inclusion
>> as without this patch the status logging feature cannot be used as it
>> will likely cause a failure of the broker.
>>
>> The patch is to create a new MessageFormater for every log message
>> rather than reusing a static formatter. I have committed the change
>> to trunk already but I'd appreciate it if we can include it for 0.6.
>
> I'm not clear from this email or the jira itself if this fits the
> criteria for blocker :-
>
> 1. Regression from 0.5 release behaviour. AND
> 2. Serious problem which will stop a user being able to use the broker.
>
> Martin
>
> If you think that it does satisfy both of these then please assign the
> bug back to you and commit the patch to the branch. Then let me know -
> I'll issue a new RC, and a call to vote.
>
> If on reflection you don't think it meets both of these criteria then
> I'll issue a call for vote on the existing RC.
>
> Andrew
Hi Andrew,
I do believe it meets your criteria:
1) Regression fro 0.5 : The broker cannot be used with the default settings.
2) Serious Problem : A broker with more than 1 connection runs the
risk of throwing this execption.
I've applied the patch to the 0.6-release branch so from my point of
view things look good for the creation of a new RC.
Cheers
Martin
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>
--
Martin Ritchie
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [0.6] Patch request for inclusion
Posted by Martin Ritchie <ri...@apache.org>.
2010/1/25 Andrew Stitcher <as...@redhat.com>:
> On Wed, 2010-01-13 at 11:08 -0500, Martin Ritchie wrote:
>> Hi Andrew,
>>
>> I've been looking at some of the Java test failures and have found an
>> issue (QPID-2137) that I would really like to be included in 0.6.
>>
>> I think this is deserving of blocking startus and therefore inclusion
>> as without this patch the status logging feature cannot be used as it
>> will likely cause a failure of the broker.
>>
>> The patch is to create a new MessageFormater for every log message
>> rather than reusing a static formatter. I have committed the change
>> to trunk already but I'd appreciate it if we can include it for 0.6.
>
> I'm not clear from this email or the jira itself if this fits the
> criteria for blocker :-
>
> 1. Regression from 0.5 release behaviour. AND
> 2. Serious problem which will stop a user being able to use the broker.
>
> Martin
>
> If you think that it does satisfy both of these then please assign the
> bug back to you and commit the patch to the branch. Then let me know -
> I'll issue a new RC, and a call to vote.
>
> If on reflection you don't think it meets both of these criteria then
> I'll issue a call for vote on the existing RC.
>
> Andrew
Hi Andrew,
I do believe it meets your criteria:
1) Regression fro 0.5 : The broker cannot be used with the default settings.
2) Serious Problem : A broker with more than 1 connection runs the
risk of throwing this execption.
I've applied the patch to the 0.6-release branch so from my point of
view things look good for the creation of a new RC.
Cheers
Martin
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>
--
Martin Ritchie
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [0.6] Patch request for inclusion
Posted by Andrew Stitcher <as...@redhat.com>.
On Wed, 2010-01-13 at 11:08 -0500, Martin Ritchie wrote:
> Hi Andrew,
>
> I've been looking at some of the Java test failures and have found an
> issue (QPID-2137) that I would really like to be included in 0.6.
>
> I think this is deserving of blocking startus and therefore inclusion
> as without this patch the status logging feature cannot be used as it
> will likely cause a failure of the broker.
>
> The patch is to create a new MessageFormater for every log message
> rather than reusing a static formatter. I have committed the change
> to trunk already but I'd appreciate it if we can include it for 0.6.
I'm not clear from this email or the jira itself if this fits the
criteria for blocker :-
1. Regression from 0.5 release behaviour. AND
2. Serious problem which will stop a user being able to use the broker.
Martin
If you think that it does satisfy both of these then please assign the
bug back to you and commit the patch to the branch. Then let me know -
I'll issue a new RC, and a call to vote.
If on reflection you don't think it meets both of these criteria then
I'll issue a call for vote on the existing RC.
Andrew
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org