You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Florian Weitling (JIRA)" <ji...@apache.org> on 2007/08/24 10:24:31 UTC

[jira] Created: (COCOON-2126) CForms-Ajax-Update sends instead of

CForms-Ajax-Update sends <span> instead of <td>
-----------------------------------------------

                 Key: COCOON-2126
                 URL: https://issues.apache.org/jira/browse/COCOON-2126
             Project: Cocoon
          Issue Type: Bug
          Components: Blocks: Ajax, Blocks: Forms
    Affects Versions: 2.1.10
            Reporter: Florian Weitling


In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.

My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski reassigned COCOON-2126:
--------------------------------------------

    Assignee:     (was: Grzegorz Kossakowski)

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>         Attachments: cocoon-forms-impl-debugAtAllCosts.patch, COCOON2126.tar.gz, screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Sylvain Wallez (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554366 ] 

Sylvain Wallez commented on COCOON-2126:
----------------------------------------

A bit of warning: widgets are not block-level components, and are allowed in places where HTML would forbid a div. For example, it is perfectly legal to include a <fd:label> in a <b> tag where a <div> is not allowed. So replacing the <span> with a <div> can actually do more harm than good as a general solution.

So we must have a special behavior for replacements in a <tr> that inserts a <td> rather than a <span>.

Handling this server-side in jx-macros.xml (or JXMacrosHelper) seems quite complicated since we can't grab what is sent to the cocoonConsumer by the JXTemplateGenerator.

The easiest way is most probably to handle this special case in BUHandler.js, in the handlers.replace function: if oldElement is a <td> and firstChild is an empty <span>, then replace firstChild with an empty <td> *with the proper id attribute* (so that it can be replaced again later).

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>            Assignee: Grzegorz Kossakowski
>         Attachments: screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Florian Weitling (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554186 ] 

Florian Weitling commented on COCOON-2126:
------------------------------------------

Hi Grek,

I doubt this issue is so important that you even have to spend your
spare sunday-before-Xmas-time on it.
But I try to help and not to stand in your way ;-)

Thank you very much!
Florian



> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>            Assignee: Grzegorz Kossakowski
>         Attachments: screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski updated COCOON-2126:
-----------------------------------------

    Attachment: COCOON2126.tar.gz

Attaching whole block for Cocoon 2.2 created from files provided by Florian. It has all infrastructure set up so you just need to go into main directory and call:
mvn jetty:run
and start playing with the issue (assuming you have latest trunk version compiled and installed into your local Maven repository).

I attach this for the case someone else wants to fix this issue.

As for now I'm unassigning myself.

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>            Assignee: Grzegorz Kossakowski
>         Attachments: cocoon-forms-impl-debugAtAllCosts.patch, COCOON2126.tar.gz, screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554181 ] 

Grzegorz Kossakowski commented on COCOON-2126:
----------------------------------------------

FYI: I'll play with this issue today's afternoon and it's likely I will have additional questions.

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>            Assignee: Grzegorz Kossakowski
>         Attachments: screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Florian Weitling (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florian Weitling updated COCOON-2126:
-------------------------------------

    Attachment: screenshot-3.jpg

After redisplaying the cell. Note the gap between "en" and "fr" cells. This grows when hitting "ShowEnglish" several times.

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>         Attachments: screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554428 ] 

Grzegorz Kossakowski commented on COCOON-2126:
----------------------------------------------

Thanks Sylvain for you insightful comments!

I agree with you that handling this on client side is the best solution. I also like your proposed solution (even it's not the cleanest one) but I couldn't came up with any working code. I had some troubles with debugging Dojo and given up.

So if someone can give me some advice why debugAtAllCosts does not work throwing following error:
mll[x] is not a function
http://localhost:8888/cocoon-ajax-impl/resource/external/dojo/dojo.js
Line 239

I could get back on this. Even more, if someone (Florian?) submits a patch I'll be happy to include it.

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>            Assignee: Grzegorz Kossakowski
>         Attachments: screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Florian Weitling (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florian Weitling updated COCOON-2126:
-------------------------------------

    Attachment: sitemap-excerpt.xmap

Excerpt of the sitemap - just standard

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>         Attachments: showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Florian Weitling (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florian Weitling updated COCOON-2126:
-------------------------------------

    Attachment: screenshot-1.jpg

Before any action

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>         Attachments: screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Florian Weitling (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florian Weitling updated COCOON-2126:
-------------------------------------

    Attachment: showQuestion.bind.xml

standard binding

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>         Attachments: showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski updated COCOON-2126:
-----------------------------------------

    Attachment: cocoon-forms-impl-debugAtAllCosts.patch

I'm including a simple (and hacky) patch that enables dojo's debugAtAllCosts option if needed. To be applied on cocoon-forms-impl module from trunk.

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>            Assignee: Grzegorz Kossakowski
>         Attachments: cocoon-forms-impl-debugAtAllCosts.patch, screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Florian Weitling (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florian Weitling updated COCOON-2126:
-------------------------------------

    Attachment: showQuestion.def.xml

standard definition

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>         Attachments: showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski reassigned COCOON-2126:
--------------------------------------------

    Assignee: Grzegorz Kossakowski

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>            Assignee: Grzegorz Kossakowski
>         Attachments: screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Florian Weitling (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florian Weitling updated COCOON-2126:
-------------------------------------

    Attachment: screenshot-2.jpg

After hiding the second cell

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>         Attachments: screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski updated COCOON-2126:
-----------------------------------------

    Affects version (Component): Parent values: Blocks: Forms(10167). Level 1 values: 1.0.0-RC1(10321). 

This issue affects Forms 1.0.0-RC1 (and earlier) also.

I found out why it sends <span> tag instead of <td>. It's done that way because <span> tag was chosen as a general placeholder for inactive/hidden widgets. It's wrong for two reasons:
1. Widget is a block-level element so <div> (used as container for block-level elements) should be used instead of <span> which is used as container for inline elements.
2. Widget can behave as a table cell which is counter-intuitive behaviour on its own but when <span> is used as placeholder it simply blows up.

The fix will probably consist of special treatment of the case when hidden widget is a whole RepeaterRow. I have some ideas how to fix this issue but I need to dig further into rendering guts of Forms to see if my ideas are generic enough.

What's more I'm going to fix trunk first and only then port the fix back to 2.1.x branch. It's caused by the fact that I lost ability to work effectively with 2.1.x. Compared with 2.2 it looks sooo much painful and inconvenient to do anything non-trivial...

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>            Assignee: Grzegorz Kossakowski
>         Attachments: screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Florian Weitling (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florian Weitling updated COCOON-2126:
-------------------------------------

    Attachment: showQuestion.js

standard flowscript

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>         Attachments: showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-2126) CForms-Ajax-Update sends instead of

Posted by "Florian Weitling (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florian Weitling updated COCOON-2126:
-------------------------------------

    Attachment: showQuestion.tmpl.xml

standard template

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>
>                 Key: COCOON-2126
>                 URL: https://issues.apache.org/jira/browse/COCOON-2126
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>         Attachments: showQuestion.bind.xml, showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
>
>
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span> is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.