[GitHub] [openwhisk-package-alarms] upgle commented on a change in pull request #198: Make cron triggers fire with random delay with parameter `strict`

[GitBox <gi...@apache.org>]

upgle commented on a change in pull request #198: Make cron triggers fire with random delay with parameter `strict`
URL: https://github.com/apache/openwhisk-package-alarms/pull/198#discussion_r388145370
 
 

 ##########
 File path: action/alarmWebAction.js
 ##########
 @@ -103,6 +103,7 @@ function main(params) {
                     }
                     newTrigger.cron = params.cron;
                     newTrigger.timezone = params.timezone;
+                    newTrigger.strict = params.strict === 'true';
 
 Review comment:
   Hmm.. If there is no `strict` parameter passed, it becomes false.
   
   It has to check null and undefined type:
   ```
   newTrigger.strict = params.strict === 'true' || params.strict === undefined || params.strict == null;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services