You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/03/28 00:49:47 UTC
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Hello Will Berkeley, Mike Percy, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12872
to review the following change.
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
java: ensure KuduTestHarness or RetryRule in every test
Now that test reporting is built into the RetryRule, we should ensure that
every test uses either RetryRule or KuduTestHarness (which wraps RetryRule).
This patch adds RetryRule to all tests that were missing one of the two.
Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
---
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBitSet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBloomFilter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBytes.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestColumnRangePredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestErrorCollector.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRequestTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRpcTraces.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatus.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTableLocationsCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeoutTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestAsyncUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestByteVec.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestMurmurHash.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestNetUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestStringUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestResultReporter.java
27 files changed, 193 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/12872/1
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Mar 2019 16:58:59 +0000
Gerrit-HasComments: No
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12872
to look at the new patch set (#2).
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
java: ensure KuduTestHarness or RetryRule in every test
Now that test reporting is built into the RetryRule, we should ensure that
every test uses either RetryRule or KuduTestHarness (which wraps RetryRule).
This patch adds RetryRule to all tests that were missing one of the two.
Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
---
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBitSet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBloomFilter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBytes.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestColumnRangePredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestErrorCollector.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRequestTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRpcTraces.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatus.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTableLocationsCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeoutTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestAsyncUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestByteVec.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestMurmurHash.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestNetUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestStringUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestResultReporter.java
27 files changed, 193 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/12872/2
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 6
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 03 Apr 2019 13:34:46 +0000
Gerrit-HasComments: No
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Apr 2019 13:17:38 +0000
Gerrit-HasComments: No
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
java: ensure KuduTestHarness or RetryRule in every test
Now that test reporting is built into the RetryRule, we should ensure that
every test uses either RetryRule or KuduTestHarness (which wraps RetryRule).
This patch adds RetryRule to all tests that were missing one of the two.
Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Reviewed-on: http://gerrit.cloudera.org:8080/12872
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBitSet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBloomFilter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestBytes.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestColumnRangePredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestErrorCollector.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRequestTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRpcTraces.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestServerInfo.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatus.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTableLocationsCache.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeoutTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestAsyncUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestByteVec.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestMurmurHash.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestNetUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestStringUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/junit/TestResultReporter.java
27 files changed, 193 insertions(+), 46 deletions(-)
Approvals:
Adar Dembo: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 7
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Mar 2019 14:05:38 +0000
Gerrit-HasComments: No
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Patch Set 6: Verified+1
Overriding Jenkins, hit KUDU-2432.
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 6
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 03 Apr 2019 03:22:59 +0000
Gerrit-HasComments: No
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Patch Set 2: Verified+1
Overriding Jenkins, unrelated test failure.
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Mar 2019 20:50:27 +0000
Gerrit-HasComments: No
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 01 Apr 2019 22:54:20 +0000
Gerrit-HasComments: No
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed a vote on this change.
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Apr 2019 01:43:10 +0000
Gerrit-HasComments: No
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Patch Set 1:
I thought about doing this when the RetryRule was introduced, but left it off of these tests because there really is no way they could be flaky. They don't talk to an external service and they don't depending on tricky things like timing. They are just pure in/out unit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Mar 2019 01:25:49 +0000
Gerrit-HasComments: No
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Patch Set 4: Verified+1
Overriding Jenkins, unrelated test failure.
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 29 Mar 2019 20:01:36 +0000
Gerrit-HasComments: No
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Patch Set 2:
Makes sense. I had forgot that we report on success too.
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Mar 2019 16:58:54 +0000
Gerrit-HasComments: No
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 6
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Patch Set 5: Verified+1
Overriding Jenkins, unrelated TSAN test failures.
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Apr 2019 03:24:14 +0000
Gerrit-HasComments: No
[kudu-CR] java: ensure KuduTestHarness or RetryRule in every test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12872 )
Change subject: java: ensure KuduTestHarness or RetryRule in every test
......................................................................
Patch Set 1:
> I thought about doing this when the RetryRule was introduced, but left it off of these tests because there really is no way they could be flaky. They don't talk to an external service and they don't depending on tricky things like timing. They are just pure in/out unit tests.
From a reporting standpoint, we absolutely want every single test to report in. Besides parity with the C++ reporting infrastructure, comprehensive data collection could open up new dashboard use cases in the future. For example, maybe we want to get a sense for how many times a day a given test runs.
I'm willing to grant that these simple tests may not need _retrying_ (though I'm skeptical about that: show me your algorithm that _proves_ whether a test can be flaky or not). However, the coupling of ResultReporter and RetryRule makes it impractical to get the former without the latter (i.e. converting ResultReporter into a @Rule just to handle these cases doesn't seem worthwhile to me).
Also, this makes the guidance for adding new Java tests really straight-forward: add the KuduTestHarness rule if you need a minicluster; otherwise, add the RetryRule rule. There are no exceptions.
--
To view, visit http://gerrit.cloudera.org:8080/12872
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I951f9fbb516abdb24a74d5a2acd7e1f1cd8a6fa5
Gerrit-Change-Number: 12872
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Mar 2019 03:41:59 +0000
Gerrit-HasComments: No