You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Bryan Duxbury <br...@rapleaf.com> on 2010/08/16 22:56:22 UTC
[VOTE] Thrift 0.4.0 RC1
Hi all,
As discussed, in all the time it took for us to finally release Thrift 0.3,
we've accumulated enough changes for Thrift 0.4!
I propose we accept
http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
the official Thrift 0.4.0 release.
I created this tarball by checking out URL:
https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running
"./bootstrap.sh && ./configure && make dist".
The GPG signature for this tarball can be found at
http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
dc.
Please download, verify the signatures, untar, and install and test the
libraries you are familiar with. We need your +1 votes to make the release!
If you encounter any problems, please let me know immediately. This vote
will close 72 hours from now.
This release consists of 45 tickets that cover many bugs and performance
improvements. Please refer to the CHANGES file for the full list. In
addition, I've rolled back a commit to the PHP extension that was causing
build errors on non-Mac platforms.
-Bryan
Re: [VOTE] Thrift 0.4.0 RC1
Posted by Bryan Duxbury <br...@rapleaf.com>.
Thanks Greg!
I think that #1 is something related to Java version - I seem to remember
this having to do with 1.4 vs 1.5 (or 1.5 vs 1.6), but I can't recall the
details.
#2 is something we're going to address for 0.5.
-Bryan
On Fri, Aug 20, 2010 at 11:09 AM, Greg Stein <gs...@gmail.com> wrote:
> I just gave a +1 over on general@incubator to release this.
>
> I ran into a couple issues which are (likely) local:
>
> 1) thrift/TUnion.java:230: method does not override a method from its
> superclass. I just reconfigure'd --without-java.
> 2) "make check" ran into a problem with -lboost_unit_test_framework.
> I'm on a Mac, and I saw else-thread that this may be an issue with my
> local installation.
>
> So... I gave my +1 because these seem like issues that are local. Best
> to be solved for "all" users out there in some way, but certainly not
> showstoppers for 0.4.0.
>
> Cheers,
> -g
>
> On Mon, Aug 16, 2010 at 16:56, Bryan Duxbury <br...@rapleaf.com> wrote:
> > Hi all,
> >
> > As discussed, in all the time it took for us to finally release Thrift
> 0.3,
> > we've accumulated enough changes for Thrift 0.4!
> >
> > I propose we accept
> > http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>
> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
> > the official Thrift 0.4.0 release.
> >
> > I created this tarball by checking out URL:
> > https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
> running
> > "./bootstrap.sh && ./configure && make dist".
> >
> > The GPG signature for this tarball can be found at
> > http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>
> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
> > It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
> > dc.
> >
> > Please download, verify the signatures, untar, and install and test the
> > libraries you are familiar with. We need your +1 votes to make the
> release!
> > If you encounter any problems, please let me know immediately. This vote
> > will close 72 hours from now.
> >
> > This release consists of 45 tickets that cover many bugs and performance
> > improvements. Please refer to the CHANGES file for the full list. In
> > addition, I've rolled back a commit to the PHP extension that was causing
> > build errors on non-Mac platforms.
> >
> > -Bryan
> >
>
Re: [VOTE] Thrift 0.4.0 RC1
Posted by Greg Stein <gs...@gmail.com>.
I just gave a +1 over on general@incubator to release this.
I ran into a couple issues which are (likely) local:
1) thrift/TUnion.java:230: method does not override a method from its
superclass. I just reconfigure'd --without-java.
2) "make check" ran into a problem with -lboost_unit_test_framework.
I'm on a Mac, and I saw else-thread that this may be an issue with my
local installation.
So... I gave my +1 because these seem like issues that are local. Best
to be solved for "all" users out there in some way, but certainly not
showstoppers for 0.4.0.
Cheers,
-g
On Mon, Aug 16, 2010 at 16:56, Bryan Duxbury <br...@rapleaf.com> wrote:
> Hi all,
>
> As discussed, in all the time it took for us to finally release Thrift 0.3,
> we've accumulated enough changes for Thrift 0.4!
>
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
> the official Thrift 0.4.0 release.
>
> I created this tarball by checking out URL:
> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running
> "./bootstrap.sh && ./configure && make dist".
>
> The GPG signature for this tarball can be found at
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
> It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
> dc.
>
> Please download, verify the signatures, untar, and install and test the
> libraries you are familiar with. We need your +1 votes to make the release!
> If you encounter any problems, please let me know immediately. This vote
> will close 72 hours from now.
>
> This release consists of 45 tickets that cover many bugs and performance
> improvements. Please refer to the CHANGES file for the full list. In
> addition, I've rolled back a commit to the PHP extension that was causing
> build errors on non-Mac platforms.
>
> -Bryan
>
Re: JIRA Config suggestions.
Posted by Bryan Duxbury <br...@rapleaf.com>.
On Thu, Aug 19, 2010 at 8:29 AM, Florentine, Justin F. <
Justin.F.Florentine@espn.com> wrote:
> 1) Can we add a component for Compiler (AS3)?
>
Done.
>
> 2) There don't seem to be any options to govern email notifications on
> changes. I thought this was pretty standard in JIRA. Can we make sure this
> is enabled... my watched issues are getting lost in the noise.
>
If you're watching an issue, it should come to your inbox, addressed
directly to you. If you are subscribed to the thrift-dev mailing list, then
you'll also get all of the issue traffic that JIRA sees. We could consider
making a new thrift-issues mailing list if we don't want to have the traffic
on the dev list.
>
> Thanks.
Re: JIRA Config suggestions.
Posted by Aron Sogor <bi...@gmail.com>.
I would be happy to help collect the patches for AS3.
I volunteer to maintain AS3, given we figure out how to get the
patches integrated to the main line easiest.
Aron
On Thu, Aug 19, 2010 at 8:29 AM, Florentine, Justin F.
<Ju...@espn.com> wrote:
> 1) Can we add a component for Compiler (AS3)?
>
> 2) There don't seem to be any options to govern email notifications on changes. I thought this was pretty standard in JIRA. Can we make sure this is enabled... my watched issues are getting lost in the noise.
>
> Thanks.
JIRA Config suggestions.
Posted by "Florentine, Justin F." <Ju...@espn.com>.
1) Can we add a component for Compiler (AS3)?
2) There don't seem to be any options to govern email notifications on changes. I thought this was pretty standard in JIRA. Can we make sure this is enabled... my watched issues are getting lost in the noise.
Thanks.
Re: [VOTE] Thrift 0.4.0 RC1
Posted by Bruce Lowekamp <br...@skype.net>.
https://issues.apache.org/jira/browse/THRIFT-857
On Aug 18, 2010, at 4:24 PM, Bruce Lowekamp wrote:
> -1
>
> Sorry to pop in so late. I've been meaning to get to tracking thrift development, and the last couple days seemed like a good opportunity, so I've been catching up on it and merging some of our stuff.
>
> We build with quite a few of the generators disabled. The patch for THRIFT-133 to parse/t_program.h (r980498) added a check if the generator in a namespace declaration is known and throws if not. Makes sense, but this makes it impossible to pass the sanity checks that are run by "make install" in test when generators are disabled (ThriftTest.thrift requires java, cpp, rb, perl, csharp, js).
>
> Obviously re-enabling the generators is pretty easy, but seems like either the configure flags for generators should be removed, the tests should be modified so that the namespace declarations are auto-generated based on configuration, or warnings should be added to the configure
>
> I'd personally be in favor of removing the --disable-gen flags for "core" libraries. (that are specified in the test.thrift files). Though pre-processing them isn't that bad of an idea.
>
> Somewhat minor/corner-case issue. Seems like it might be a little unfriendly to newcomers who experiment, though.
>
> I'll open a jira issue.
>
> Bruce
>
>
>
> On Aug 18, 2010, at 1:59 PM, roger@bufferoverflow.ch wrote:
>
>> +1
>>
>> I've built the following languages successfully:
>> cpp, java, erlang, ruby, perl, python
>>
>> and the following available Unit Tests passed:
>> cpp, java
>>
>> see:
>> http://www.bufferoverflow.ch/hudson/job/Thrift-0.4.0/default/lastStableBuild/
>>
>>
>>
>>
>> Quoting Bryan Duxbury <br...@rapleaf.com>:
>>
>>> Hi all,
>>>
>>> As discussed, in all the time it took for us to finally release Thrift 0.3,
>>> we've accumulated enough changes for Thrift 0.4!
>>>
>>> I propose we accept
>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
>>> the official Thrift 0.4.0 release.
>>>
>>> I created this tarball by checking out URL:
>>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running
>>> "./bootstrap.sh && ./configure && make dist".
>>>
>>> The GPG signature for this tarball can be found at
>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
>>> It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
>>> dc.
>>>
>>> Please download, verify the signatures, untar, and install and test the
>>> libraries you are familiar with. We need your +1 votes to make the release!
>>> If you encounter any problems, please let me know immediately. This vote
>>> will close 72 hours from now.
>>>
>>> This release consists of 45 tickets that cover many bugs and performance
>>> improvements. Please refer to the CHANGES file for the full list. In
>>> addition, I've rolled back a commit to the PHP extension that was causing
>>> build errors on non-Mac platforms.
>>>
>>> -Bryan
>>>
>>
>>
>>
>> ----------------------------------------------------------------
>> This message was sent using IMP, the Internet Messaging Program.
>>
>
Re: [VOTE] Thrift 0.4.0 RC1
Posted by Bryan Duxbury <br...@rapleaf.com>.
On Wed, Aug 18, 2010 at 11:40 PM, Anthony Molinaro <
anthonym@alumni.caltech.edu> wrote:
> I think 0.4 can probably be released without this, but I think it's a
> good goal for 0.5.
>
> -Anthony
>
> On Thu, Aug 19, 2010 at 07:36:03AM +0200, Bruce Lowekamp wrote:
> > I'm ok with not blocking the release on it. Maybe there should be release
> notes (don't disable generators, don't run bootstrap). I think I would have
> run into it because I think the first time I built thrift I had to disable
> something to get it to work, but if the goal is for faster releases, I think
> I'm ok with that.
>
OK, since we seem to have made some decisions about putting off this fix
until the next release, and 72 hours has passed, the vote has passed.
We had 7 +1 votes, including 3 from active Thrift committers (myself, David,
and Mark) and one mentor (Doug). I'll push this up to the general list to
get the binding vote done.
Re: [VOTE] Thrift 0.4.0 RC1
Posted by Bryan Duxbury <br...@rapleaf.com>.
I think that disabling the library build of a given library should certainly
disable its tests. However, I still don't understand why someone would want
to disable a generator in the compiler. What does it cost you to have the
generator as an option?
On Wed, Aug 18, 2010 at 11:40 PM, Anthony Molinaro <
anthonym@alumni.caltech.edu> wrote:
> I'm of the opinion that it should be possible to disable a generator, but
> I think it should be the same switch as disables the runtime library for
> a particular language. I think this makes the most sense, since I don't
> see many reasonse to generate bindings which you can't actually compile
> and run. I'll poke around through the build system to check, but I'm
> pretty confident it should be very possible to use the same configure
> option to disable the generator, the building of the runtime library
> and the running of the tests.
>
> I think 0.4 can probably be released without this, but I think it's a
> good goal for 0.5.
>
> -Anthony
>
> On Thu, Aug 19, 2010 at 07:36:03AM +0200, Bruce Lowekamp wrote:
> > I'm ok with not blocking the release on it. Maybe there should be release
> notes (don't disable generators, don't run bootstrap). I think I would have
> run into it because I think the first time I built thrift I had to disable
> something to get it to work, but if the goal is for faster releases, I think
> I'm ok with that.
> >
> > Bruce
> >
> > Sent from my iPhone
> >
> > On Aug 18, 2010, at 21:55, Bryan Duxbury <br...@rapleaf.com> wrote:
> >
> > > Bruce - I commented on your ticket, and I agree that we should make
> some
> > > changes. However, do you really think this is important enough for us
> to
> > > torpedo the RC? I don't see this as something critical enough that we
> would
> > > have made it a blocker for the release.
> > >
> > > On Wed, Aug 18, 2010 at 4:24 PM, Bruce Lowekamp <
> bruce.lowekamp@skype.net>wrote:
> > >
> > >> -1
> > >>
> > >> Sorry to pop in so late. I've been meaning to get to tracking thrift
> > >> development, and the last couple days seemed like a good opportunity,
> so
> > >> I've been catching up on it and merging some of our stuff.
> > >>
> > >> We build with quite a few of the generators disabled. The patch for
> > >> THRIFT-133 to parse/t_program.h (r980498) added a check if the
> generator in
> > >> a namespace declaration is known and throws if not. Makes sense, but
> this
> > >> makes it impossible to pass the sanity checks that are run by "make
> install"
> > >> in test when generators are disabled (ThriftTest.thrift requires java,
> cpp,
> > >> rb, perl, csharp, js).
> > >>
> > >> Obviously re-enabling the generators is pretty easy, but seems like
> either
> > >> the configure flags for generators should be removed, the tests should
> be
> > >> modified so that the namespace declarations are auto-generated based
> on
> > >> configuration, or warnings should be added to the configure
> > >>
> > >> I'd personally be in favor of removing the --disable-gen flags for
> "core"
> > >> libraries. (that are specified in the test.thrift files). Though
> > >> pre-processing them isn't that bad of an idea.
> > >>
> > >> Somewhat minor/corner-case issue. Seems like it might be a little
> > >> unfriendly to newcomers who experiment, though.
> > >>
> > >> I'll open a jira issue.
> > >>
> > >> Bruce
> > >>
> > >>
> > >>
> > >> On Aug 18, 2010, at 1:59 PM, roger@bufferoverflow.ch wrote:
> > >>
> > >>> +1
> > >>>
> > >>> I've built the following languages successfully:
> > >>> cpp, java, erlang, ruby, perl, python
> > >>>
> > >>> and the following available Unit Tests passed:
> > >>> cpp, java
> > >>>
> > >>> see:
> > >>>
> > >>
> http://www.bufferoverflow.ch/hudson/job/Thrift-0.4.0/default/lastStableBuild/
> > >>>
> > >>>
> > >>>
> > >>>
> > >>> Quoting Bryan Duxbury <br...@rapleaf.com>:
> > >>>
> > >>>> Hi all,
> > >>>>
> > >>>> As discussed, in all the time it took for us to finally release
> Thrift
> > >> 0.3,
> > >>>> we've accumulated enough changes for Thrift 0.4!
> > >>>>
> > >>>> I propose we accept
> > >>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>
> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>
> > >> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
> > >>>> the official Thrift 0.4.0 release.
> > >>>>
> > >>>> I created this tarball by checking out URL:
> > >>>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.xand
> > >> running
> > >>>> "./bootstrap.sh && ./configure && make dist".
> > >>>>
> > >>>> The GPG signature for this tarball can be found at
> > >>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>
> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>
> > >> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc
> >.
> > >>>> It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
> > >>>> dc.
> > >>>>
> > >>>> Please download, verify the signatures, untar, and install and test
> the
> > >>>> libraries you are familiar with. We need your +1 votes to make the
> > >> release!
> > >>>> If you encounter any problems, please let me know immediately. This
> vote
> > >>>> will close 72 hours from now.
> > >>>>
> > >>>> This release consists of 45 tickets that cover many bugs and
> performance
> > >>>> improvements. Please refer to the CHANGES file for the full list. In
> > >>>> addition, I've rolled back a commit to the PHP extension that was
> > >> causing
> > >>>> build errors on non-Mac platforms.
> > >>>>
> > >>>> -Bryan
> > >>>>
> > >>>
> > >>>
> > >>>
> > >>> ----------------------------------------------------------------
> > >>> This message was sent using IMP, the Internet Messaging Program.
> > >>>
> > >>
> > >>
> >
>
> --
> ------------------------------------------------------------------------
> Anthony Molinaro <an...@alumni.caltech.edu>
>
Re: [VOTE] Thrift 0.4.0 RC1
Posted by Anthony Molinaro <an...@alumni.caltech.edu>.
I'm of the opinion that it should be possible to disable a generator, but
I think it should be the same switch as disables the runtime library for
a particular language. I think this makes the most sense, since I don't
see many reasonse to generate bindings which you can't actually compile
and run. I'll poke around through the build system to check, but I'm
pretty confident it should be very possible to use the same configure
option to disable the generator, the building of the runtime library
and the running of the tests.
I think 0.4 can probably be released without this, but I think it's a
good goal for 0.5.
-Anthony
On Thu, Aug 19, 2010 at 07:36:03AM +0200, Bruce Lowekamp wrote:
> I'm ok with not blocking the release on it. Maybe there should be release notes (don't disable generators, don't run bootstrap). I think I would have run into it because I think the first time I built thrift I had to disable something to get it to work, but if the goal is for faster releases, I think I'm ok with that.
>
> Bruce
>
> Sent from my iPhone
>
> On Aug 18, 2010, at 21:55, Bryan Duxbury <br...@rapleaf.com> wrote:
>
> > Bruce - I commented on your ticket, and I agree that we should make some
> > changes. However, do you really think this is important enough for us to
> > torpedo the RC? I don't see this as something critical enough that we would
> > have made it a blocker for the release.
> >
> > On Wed, Aug 18, 2010 at 4:24 PM, Bruce Lowekamp <br...@skype.net>wrote:
> >
> >> -1
> >>
> >> Sorry to pop in so late. I've been meaning to get to tracking thrift
> >> development, and the last couple days seemed like a good opportunity, so
> >> I've been catching up on it and merging some of our stuff.
> >>
> >> We build with quite a few of the generators disabled. The patch for
> >> THRIFT-133 to parse/t_program.h (r980498) added a check if the generator in
> >> a namespace declaration is known and throws if not. Makes sense, but this
> >> makes it impossible to pass the sanity checks that are run by "make install"
> >> in test when generators are disabled (ThriftTest.thrift requires java, cpp,
> >> rb, perl, csharp, js).
> >>
> >> Obviously re-enabling the generators is pretty easy, but seems like either
> >> the configure flags for generators should be removed, the tests should be
> >> modified so that the namespace declarations are auto-generated based on
> >> configuration, or warnings should be added to the configure
> >>
> >> I'd personally be in favor of removing the --disable-gen flags for "core"
> >> libraries. (that are specified in the test.thrift files). Though
> >> pre-processing them isn't that bad of an idea.
> >>
> >> Somewhat minor/corner-case issue. Seems like it might be a little
> >> unfriendly to newcomers who experiment, though.
> >>
> >> I'll open a jira issue.
> >>
> >> Bruce
> >>
> >>
> >>
> >> On Aug 18, 2010, at 1:59 PM, roger@bufferoverflow.ch wrote:
> >>
> >>> +1
> >>>
> >>> I've built the following languages successfully:
> >>> cpp, java, erlang, ruby, perl, python
> >>>
> >>> and the following available Unit Tests passed:
> >>> cpp, java
> >>>
> >>> see:
> >>>
> >> http://www.bufferoverflow.ch/hudson/job/Thrift-0.4.0/default/lastStableBuild/
> >>>
> >>>
> >>>
> >>>
> >>> Quoting Bryan Duxbury <br...@rapleaf.com>:
> >>>
> >>>> Hi all,
> >>>>
> >>>> As discussed, in all the time it took for us to finally release Thrift
> >> 0.3,
> >>>> we've accumulated enough changes for Thrift 0.4!
> >>>>
> >>>> I propose we accept
> >>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>
> >> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
> >>>> the official Thrift 0.4.0 release.
> >>>>
> >>>> I created this tarball by checking out URL:
> >>>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
> >> running
> >>>> "./bootstrap.sh && ./configure && make dist".
> >>>>
> >>>> The GPG signature for this tarball can be found at
> >>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>
> >> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
> >>>> It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
> >>>> dc.
> >>>>
> >>>> Please download, verify the signatures, untar, and install and test the
> >>>> libraries you are familiar with. We need your +1 votes to make the
> >> release!
> >>>> If you encounter any problems, please let me know immediately. This vote
> >>>> will close 72 hours from now.
> >>>>
> >>>> This release consists of 45 tickets that cover many bugs and performance
> >>>> improvements. Please refer to the CHANGES file for the full list. In
> >>>> addition, I've rolled back a commit to the PHP extension that was
> >> causing
> >>>> build errors on non-Mac platforms.
> >>>>
> >>>> -Bryan
> >>>>
> >>>
> >>>
> >>>
> >>> ----------------------------------------------------------------
> >>> This message was sent using IMP, the Internet Messaging Program.
> >>>
> >>
> >>
>
--
------------------------------------------------------------------------
Anthony Molinaro <an...@alumni.caltech.edu>
Re: [VOTE] Thrift 0.4.0 RC1
Posted by Bruce Lowekamp <br...@skype.net>.
I'm ok with not blocking the release on it. Maybe there should be release notes (don't disable generators, don't run bootstrap). I think I would have run into it because I think the first time I built thrift I had to disable something to get it to work, but if the goal is for faster releases, I think I'm ok with that.
Bruce
Sent from my iPhone
On Aug 18, 2010, at 21:55, Bryan Duxbury <br...@rapleaf.com> wrote:
> Bruce - I commented on your ticket, and I agree that we should make some
> changes. However, do you really think this is important enough for us to
> torpedo the RC? I don't see this as something critical enough that we would
> have made it a blocker for the release.
>
> On Wed, Aug 18, 2010 at 4:24 PM, Bruce Lowekamp <br...@skype.net>wrote:
>
>> -1
>>
>> Sorry to pop in so late. I've been meaning to get to tracking thrift
>> development, and the last couple days seemed like a good opportunity, so
>> I've been catching up on it and merging some of our stuff.
>>
>> We build with quite a few of the generators disabled. The patch for
>> THRIFT-133 to parse/t_program.h (r980498) added a check if the generator in
>> a namespace declaration is known and throws if not. Makes sense, but this
>> makes it impossible to pass the sanity checks that are run by "make install"
>> in test when generators are disabled (ThriftTest.thrift requires java, cpp,
>> rb, perl, csharp, js).
>>
>> Obviously re-enabling the generators is pretty easy, but seems like either
>> the configure flags for generators should be removed, the tests should be
>> modified so that the namespace declarations are auto-generated based on
>> configuration, or warnings should be added to the configure
>>
>> I'd personally be in favor of removing the --disable-gen flags for "core"
>> libraries. (that are specified in the test.thrift files). Though
>> pre-processing them isn't that bad of an idea.
>>
>> Somewhat minor/corner-case issue. Seems like it might be a little
>> unfriendly to newcomers who experiment, though.
>>
>> I'll open a jira issue.
>>
>> Bruce
>>
>>
>>
>> On Aug 18, 2010, at 1:59 PM, roger@bufferoverflow.ch wrote:
>>
>>> +1
>>>
>>> I've built the following languages successfully:
>>> cpp, java, erlang, ruby, perl, python
>>>
>>> and the following available Unit Tests passed:
>>> cpp, java
>>>
>>> see:
>>>
>> http://www.bufferoverflow.ch/hudson/job/Thrift-0.4.0/default/lastStableBuild/
>>>
>>>
>>>
>>>
>>> Quoting Bryan Duxbury <br...@rapleaf.com>:
>>>
>>>> Hi all,
>>>>
>>>> As discussed, in all the time it took for us to finally release Thrift
>> 0.3,
>>>> we've accumulated enough changes for Thrift 0.4!
>>>>
>>>> I propose we accept
>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>
>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
>>>> the official Thrift 0.4.0 release.
>>>>
>>>> I created this tarball by checking out URL:
>>>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
>> running
>>>> "./bootstrap.sh && ./configure && make dist".
>>>>
>>>> The GPG signature for this tarball can be found at
>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>
>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
>>>> It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
>>>> dc.
>>>>
>>>> Please download, verify the signatures, untar, and install and test the
>>>> libraries you are familiar with. We need your +1 votes to make the
>> release!
>>>> If you encounter any problems, please let me know immediately. This vote
>>>> will close 72 hours from now.
>>>>
>>>> This release consists of 45 tickets that cover many bugs and performance
>>>> improvements. Please refer to the CHANGES file for the full list. In
>>>> addition, I've rolled back a commit to the PHP extension that was
>> causing
>>>> build errors on non-Mac platforms.
>>>>
>>>> -Bryan
>>>>
>>>
>>>
>>>
>>> ----------------------------------------------------------------
>>> This message was sent using IMP, the Internet Messaging Program.
>>>
>>
>>
Re: [VOTE] Thrift 0.4.0 RC1
Posted by Bryan Duxbury <br...@rapleaf.com>.
Bruce - I commented on your ticket, and I agree that we should make some
changes. However, do you really think this is important enough for us to
torpedo the RC? I don't see this as something critical enough that we would
have made it a blocker for the release.
On Wed, Aug 18, 2010 at 4:24 PM, Bruce Lowekamp <br...@skype.net>wrote:
> -1
>
> Sorry to pop in so late. I've been meaning to get to tracking thrift
> development, and the last couple days seemed like a good opportunity, so
> I've been catching up on it and merging some of our stuff.
>
> We build with quite a few of the generators disabled. The patch for
> THRIFT-133 to parse/t_program.h (r980498) added a check if the generator in
> a namespace declaration is known and throws if not. Makes sense, but this
> makes it impossible to pass the sanity checks that are run by "make install"
> in test when generators are disabled (ThriftTest.thrift requires java, cpp,
> rb, perl, csharp, js).
>
> Obviously re-enabling the generators is pretty easy, but seems like either
> the configure flags for generators should be removed, the tests should be
> modified so that the namespace declarations are auto-generated based on
> configuration, or warnings should be added to the configure
>
> I'd personally be in favor of removing the --disable-gen flags for "core"
> libraries. (that are specified in the test.thrift files). Though
> pre-processing them isn't that bad of an idea.
>
> Somewhat minor/corner-case issue. Seems like it might be a little
> unfriendly to newcomers who experiment, though.
>
> I'll open a jira issue.
>
> Bruce
>
>
>
> On Aug 18, 2010, at 1:59 PM, roger@bufferoverflow.ch wrote:
>
> > +1
> >
> > I've built the following languages successfully:
> > cpp, java, erlang, ruby, perl, python
> >
> > and the following available Unit Tests passed:
> > cpp, java
> >
> > see:
> >
> http://www.bufferoverflow.ch/hudson/job/Thrift-0.4.0/default/lastStableBuild/
> >
> >
> >
> >
> > Quoting Bryan Duxbury <br...@rapleaf.com>:
> >
> >> Hi all,
> >>
> >> As discussed, in all the time it took for us to finally release Thrift
> 0.3,
> >> we've accumulated enough changes for Thrift 0.4!
> >>
> >> I propose we accept
> >> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>
> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
> >> the official Thrift 0.4.0 release.
> >>
> >> I created this tarball by checking out URL:
> >> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
> running
> >> "./bootstrap.sh && ./configure && make dist".
> >>
> >> The GPG signature for this tarball can be found at
> >> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>
> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
> >> It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
> >> dc.
> >>
> >> Please download, verify the signatures, untar, and install and test the
> >> libraries you are familiar with. We need your +1 votes to make the
> release!
> >> If you encounter any problems, please let me know immediately. This vote
> >> will close 72 hours from now.
> >>
> >> This release consists of 45 tickets that cover many bugs and performance
> >> improvements. Please refer to the CHANGES file for the full list. In
> >> addition, I've rolled back a commit to the PHP extension that was
> causing
> >> build errors on non-Mac platforms.
> >>
> >> -Bryan
> >>
> >
> >
> >
> > ----------------------------------------------------------------
> > This message was sent using IMP, the Internet Messaging Program.
> >
>
>
Re: [VOTE] Thrift 0.4.0 RC1
Posted by Bruce Lowekamp <br...@skype.net>.
-1
Sorry to pop in so late. I've been meaning to get to tracking thrift development, and the last couple days seemed like a good opportunity, so I've been catching up on it and merging some of our stuff.
We build with quite a few of the generators disabled. The patch for THRIFT-133 to parse/t_program.h (r980498) added a check if the generator in a namespace declaration is known and throws if not. Makes sense, but this makes it impossible to pass the sanity checks that are run by "make install" in test when generators are disabled (ThriftTest.thrift requires java, cpp, rb, perl, csharp, js).
Obviously re-enabling the generators is pretty easy, but seems like either the configure flags for generators should be removed, the tests should be modified so that the namespace declarations are auto-generated based on configuration, or warnings should be added to the configure
I'd personally be in favor of removing the --disable-gen flags for "core" libraries. (that are specified in the test.thrift files). Though pre-processing them isn't that bad of an idea.
Somewhat minor/corner-case issue. Seems like it might be a little unfriendly to newcomers who experiment, though.
I'll open a jira issue.
Bruce
On Aug 18, 2010, at 1:59 PM, roger@bufferoverflow.ch wrote:
> +1
>
> I've built the following languages successfully:
> cpp, java, erlang, ruby, perl, python
>
> and the following available Unit Tests passed:
> cpp, java
>
> see:
> http://www.bufferoverflow.ch/hudson/job/Thrift-0.4.0/default/lastStableBuild/
>
>
>
>
> Quoting Bryan Duxbury <br...@rapleaf.com>:
>
>> Hi all,
>>
>> As discussed, in all the time it took for us to finally release Thrift 0.3,
>> we've accumulated enough changes for Thrift 0.4!
>>
>> I propose we accept
>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
>> the official Thrift 0.4.0 release.
>>
>> I created this tarball by checking out URL:
>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running
>> "./bootstrap.sh && ./configure && make dist".
>>
>> The GPG signature for this tarball can be found at
>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
>> It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
>> dc.
>>
>> Please download, verify the signatures, untar, and install and test the
>> libraries you are familiar with. We need your +1 votes to make the release!
>> If you encounter any problems, please let me know immediately. This vote
>> will close 72 hours from now.
>>
>> This release consists of 45 tickets that cover many bugs and performance
>> improvements. Please refer to the CHANGES file for the full list. In
>> addition, I've rolled back a commit to the PHP extension that was causing
>> build errors on non-Mac platforms.
>>
>> -Bryan
>>
>
>
>
> ----------------------------------------------------------------
> This message was sent using IMP, the Internet Messaging Program.
>
Re: [VOTE] Thrift 0.4.0 RC1
Posted by ro...@bufferoverflow.ch.
+1
I've built the following languages successfully:
cpp, java, erlang, ruby, perl, python
and the following available Unit Tests passed:
cpp, java
see:
http://www.bufferoverflow.ch/hudson/job/Thrift-0.4.0/default/lastStableBuild/
Quoting Bryan Duxbury <br...@rapleaf.com>:
> Hi all,
>
> As discussed, in all the time it took for us to finally release Thrift 0.3,
> we've accumulated enough changes for Thrift 0.4!
>
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
> the official Thrift 0.4.0 release.
>
> I created this tarball by checking out URL:
> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running
> "./bootstrap.sh && ./configure && make dist".
>
> The GPG signature for this tarball can be found at
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
> It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
> dc.
>
> Please download, verify the signatures, untar, and install and test the
> libraries you are familiar with. We need your +1 votes to make the release!
> If you encounter any problems, please let me know immediately. This vote
> will close 72 hours from now.
>
> This release consists of 45 tickets that cover many bugs and performance
> improvements. Please refer to the CHANGES file for the full list. In
> addition, I've rolled back a commit to the PHP extension that was causing
> build errors on non-Mac platforms.
>
> -Bryan
>
----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.
Re: [VOTE] Thrift 0.4.0 RC1
Posted by Rajesh Malepati <ch...@gmail.com>.
+1
On Wed, Aug 18, 2010 at 4:56 AM, Mark Slee <ms...@facebook.com> wrote:
> Also +1
>
> -----Original Message-----
> From: Bryan Duxbury [mailto:bryan@rapleaf.com]
> Sent: Monday, August 16, 2010 1:56 PM
> To: thrift-dev@incubator.apache.org
> Subject: [VOTE] Thrift 0.4.0 RC1
>
> Hi all,
>
> As discussed, in all the time it took for us to finally release Thrift 0.3,
> we've accumulated enough changes for Thrift 0.4!
>
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
> the official Thrift 0.4.0 release.
>
> I created this tarball by checking out URL:
> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running
> "./bootstrap.sh && ./configure && make dist".
>
> The GPG signature for this tarball can be found at
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
> It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
> dc.
>
> Please download, verify the signatures, untar, and install and test the
> libraries you are familiar with. We need your +1 votes to make the release!
> If you encounter any problems, please let me know immediately. This vote
> will close 72 hours from now.
>
> This release consists of 45 tickets that cover many bugs and performance
> improvements. Please refer to the CHANGES file for the full list. In
> addition, I've rolled back a commit to the PHP extension that was causing
> build errors on non-Mac platforms.
>
> -Bryan
>
RE: [VOTE] Thrift 0.4.0 RC1
Posted by Mark Slee <ms...@facebook.com>.
Also +1
-----Original Message-----
From: Bryan Duxbury [mailto:bryan@rapleaf.com]
Sent: Monday, August 16, 2010 1:56 PM
To: thrift-dev@incubator.apache.org
Subject: [VOTE] Thrift 0.4.0 RC1
Hi all,
As discussed, in all the time it took for us to finally release Thrift 0.3,
we've accumulated enough changes for Thrift 0.4!
I propose we accept
http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
the official Thrift 0.4.0 release.
I created this tarball by checking out URL:
https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running
"./bootstrap.sh && ./configure && make dist".
The GPG signature for this tarball can be found at
http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
dc.
Please download, verify the signatures, untar, and install and test the
libraries you are familiar with. We need your +1 votes to make the release!
If you encounter any problems, please let me know immediately. This vote
will close 72 hours from now.
This release consists of 45 tickets that cover many bugs and performance
improvements. Please refer to the CHANGES file for the full list. In
addition, I've rolled back a commit to the PHP extension that was causing
build errors on non-Mac platforms.
-Bryan
Re: [VOTE] Thrift 0.4.0 RC1
Posted by David Reiss <dr...@facebook.com>.
+1
On 08/16/2010 01:56 PM, Bryan Duxbury wrote:
> Hi all,
>
> As discussed, in all the time it took for us to finally release Thrift 0.3,
> we've accumulated enough changes for Thrift 0.4!
>
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
> the official Thrift 0.4.0 release.
>
> I created this tarball by checking out URL:
> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running
> "./bootstrap.sh && ./configure && make dist".
>
> The GPG signature for this tarball can be found at
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
> It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
> dc.
>
> Please download, verify the signatures, untar, and install and test the
> libraries you are familiar with. We need your +1 votes to make the release!
> If you encounter any problems, please let me know immediately. This vote
> will close 72 hours from now.
>
> This release consists of 45 tickets that cover many bugs and performance
> improvements. Please refer to the CHANGES file for the full list. In
> addition, I've rolled back a commit to the PHP extension that was causing
> build errors on non-Mac platforms.
>
> -Bryan
>
Re: [VOTE] Thrift 0.4.0 RC1
Posted by Doug Cutting <cu...@apache.org>.
+1 Looks good to me.
Doug
On 08/16/2010 01:56 PM, Bryan Duxbury wrote:
> Hi all,
>
> As discussed, in all the time it took for us to finally release Thrift 0.3,
> we've accumulated enough changes for Thrift 0.4!
>
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
> the official Thrift 0.4.0 release.
>
> I created this tarball by checking out URL:
> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running
> "./bootstrap.sh&& ./configure&& make dist".
>
> The GPG signature for this tarball can be found at
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
> It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
> dc.
>
> Please download, verify the signatures, untar, and install and test the
> libraries you are familiar with. We need your +1 votes to make the release!
> If you encounter any problems, please let me know immediately. This vote
> will close 72 hours from now.
>
> This release consists of 45 tickets that cover many bugs and performance
> improvements. Please refer to the CHANGES file for the full list. In
> addition, I've rolled back a commit to the PHP extension that was causing
> build errors on non-Mac platforms.
>
> -Bryan
>
Re: [VOTE] Thrift 0.4.0 RC1
Posted by Rush Manbert <ru...@manbert.com>.
On Aug 16, 2010, at 8:12 PM, James Clarke wrote:
> -1. This failed for me on OS X. I opened THRIFT-856 which solves the
> issue, although I have no idea why I'm the only one experiencing this.
>
> make check fails because my boost is in a non-standard location.
> Adding $(BOOST_LDFLAGS)
> flags as per the RC0 email thread fixes it.
<snip>
But this is not sufficient when your boost libraries are default named. (I just tested this.) In that case the link still fails because the thread library is not named libboost_unit_test_framework.a. It has adornments for threading, debug, etc. I have a complete fix for this, but it's all rolled up in my 591 patch, and it requires the configure script to figure out the real name of the library and provide it to the lower levels.
The way the tests are written now, make check only works in certain environments.
- Rush
Re: [VOTE] Thrift 0.4.0 RC1
Posted by James Clarke <cl...@gmail.com>.
The boost thing can wait for a later release.
But I also I THRIFT-856 where the cpp library failed to compile on my
machine. Although I'm the only one who has encountered this so I
could be part of my setup...
On Wed, Aug 18, 2010 at 12:23, Bryan Duxbury <br...@rapleaf.com> wrote:
> James -
>
> If I understand correctly, it appears that you've uncovered an issue that
> has to do non-standard boost library location, right? As this isn't the
> norm, how would you feel about us addressing this in a later release?
>
> -Bryan
>
> On Mon, Aug 16, 2010 at 8:12 PM, James Clarke <cl...@gmail.com> wrote:
>>
>> -1. This failed for me on OS X. I opened THRIFT-856 which solves the
>> issue, although I have no idea why I'm the only one experiencing this.
>>
>> make check fails because my boost is in a non-standard location.
>> Adding $(BOOST_LDFLAGS)
>> flags as per the RC0 email thread fixes it.
>>
>> After those two fixes everything appears ok.
>>
>> On Mon, Aug 16, 2010 at 15:56, Bryan Duxbury <br...@rapleaf.com> wrote:
>>
>> > Hi all,
>> >
>> > As discussed, in all the time it took for us to finally release Thrift
>> > 0.3,
>> > we've accumulated enough changes for Thrift 0.4!
>> >
>> > I propose we accept
>> > http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<
>> > http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
>> > the official Thrift 0.4.0 release.
>> >
>> > I created this tarball by checking out URL:
>> > https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
>> > running
>> > "./bootstrap.sh && ./configure && make dist".
>> >
>> > The GPG signature for this tarball can be found at
>> > http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<
>> > http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
>> > It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
>> > dc.
>> >
>> > Please download, verify the signatures, untar, and install and test the
>> > libraries you are familiar with. We need your +1 votes to make the
>> > release!
>> > If you encounter any problems, please let me know immediately. This vote
>> > will close 72 hours from now.
>> >
>> > This release consists of 45 tickets that cover many bugs and performance
>> > improvements. Please refer to the CHANGES file for the full list. In
>> > addition, I've rolled back a commit to the PHP extension that was
>> > causing
>> > build errors on non-Mac platforms.
>> >
>> > -Bryan
>> >
>
>
Re: [VOTE] Thrift 0.4.0 RC1
Posted by Bryan Duxbury <br...@rapleaf.com>.
James -
If I understand correctly, it appears that you've uncovered an issue that
has to do non-standard boost library location, right? As this isn't the
norm, how would you feel about us addressing this in a later release?
-Bryan
On Mon, Aug 16, 2010 at 8:12 PM, James Clarke <cl...@gmail.com> wrote:
> -1. This failed for me on OS X. I opened THRIFT-856 which solves the
> issue, although I have no idea why I'm the only one experiencing this.
>
> make check fails because my boost is in a non-standard location.
> Adding $(BOOST_LDFLAGS)
> flags as per the RC0 email thread fixes it.
>
> After those two fixes everything appears ok.
>
> On Mon, Aug 16, 2010 at 15:56, Bryan Duxbury <br...@rapleaf.com> wrote:
>
> > Hi all,
> >
> > As discussed, in all the time it took for us to finally release Thrift
> 0.3,
> > we've accumulated enough changes for Thrift 0.4!
> >
> > I propose we accept
> > http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>
> <
> > http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
> > the official Thrift 0.4.0 release.
> >
> > I created this tarball by checking out URL:
> > https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
> > running
> > "./bootstrap.sh && ./configure && make dist".
> >
> > The GPG signature for this tarball can be found at
> > http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>
> <
> > http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
> > It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
> > dc.
> >
> > Please download, verify the signatures, untar, and install and test the
> > libraries you are familiar with. We need your +1 votes to make the
> release!
> > If you encounter any problems, please let me know immediately. This vote
> > will close 72 hours from now.
> >
> > This release consists of 45 tickets that cover many bugs and performance
> > improvements. Please refer to the CHANGES file for the full list. In
> > addition, I've rolled back a commit to the PHP extension that was causing
> > build errors on non-Mac platforms.
> >
> > -Bryan
> >
>
Re: [VOTE] Thrift 0.4.0 RC1
Posted by James Clarke <cl...@gmail.com>.
-1. This failed for me on OS X. I opened THRIFT-856 which solves the
issue, although I have no idea why I'm the only one experiencing this.
make check fails because my boost is in a non-standard location.
Adding $(BOOST_LDFLAGS)
flags as per the RC0 email thread fixes it.
After those two fixes everything appears ok.
On Mon, Aug 16, 2010 at 15:56, Bryan Duxbury <br...@rapleaf.com> wrote:
> Hi all,
>
> As discussed, in all the time it took for us to finally release Thrift 0.3,
> we've accumulated enough changes for Thrift 0.4!
>
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<
> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
> the official Thrift 0.4.0 release.
>
> I created this tarball by checking out URL:
> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
> running
> "./bootstrap.sh && ./configure && make dist".
>
> The GPG signature for this tarball can be found at
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<
> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
> It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
> dc.
>
> Please download, verify the signatures, untar, and install and test the
> libraries you are familiar with. We need your +1 votes to make the release!
> If you encounter any problems, please let me know immediately. This vote
> will close 72 hours from now.
>
> This release consists of 45 tickets that cover many bugs and performance
> improvements. Please refer to the CHANGES file for the full list. In
> addition, I've rolled back a commit to the PHP extension that was causing
> build errors on non-Mac platforms.
>
> -Bryan
>
Re: [VOTE] Thrift 0.4.0 RC1
Posted by Igor Ribeiro de Assis <ig...@gmail.com>.
+1
On Mon, Aug 16, 2010 at 1:56 PM, Bryan Duxbury <br...@rapleaf.com> wrote:
> Hi all,
>
> As discussed, in all the time it took for us to finally release Thrift 0.3,
> we've accumulated enough changes for Thrift 0.4!
>
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz>as
> the official Thrift 0.4.0 release.
>
> I created this tarball by checking out URL:
> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running
> "./bootstrap.sh && ./configure && make dist".
>
> The GPG signature for this tarball can be found at
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc1.tar.gz.asc>.
> It has an MD5 signature of bb8466e5b884e9edef862a64f57abe38.
> dc.
>
> Please download, verify the signatures, untar, and install and test the
> libraries you are familiar with. We need your +1 votes to make the release!
> If you encounter any problems, please let me know immediately. This vote
> will close 72 hours from now.
>
> This release consists of 45 tickets that cover many bugs and performance
> improvements. Please refer to the CHANGES file for the full list. In
> addition, I've rolled back a commit to the PHP extension that was causing
> build errors on non-Mac platforms.
>
> -Bryan
>
--
Igor Ribeiro de Assis