You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "ThorneANN (via GitHub)" <gi...@apache.org> on 2026/03/02 04:29:58 UTC
[PR] [Lake][Paimon] fix npe with FlussRecordAsPaimonRow [fluss]
ThorneANN opened a new pull request, #2765:
URL: https://github.com/apache/fluss/pull/2765
<!--
*Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/fluss/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
- Each pull request should address only one issue, not mix up code from multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close https://github.com/apache/fluss/pull/2764
<!-- What is the purpose of the change -->
### Brief change log
<!-- Please describe the changes made in this pull request and explain how they address the issue -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Lake][Paimon] Fix npe with FlussRecordAsPaimonRow [fluss]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on PR #2765:
URL: https://github.com/apache/fluss/pull/2765#issuecomment-3989900834
> @ThorneANN Thanks. LGTM!
@ThorneANN One minor comments: Could you please add a simple test in `FlussRecordAsPaimonRowTest` instead of introduing a new test class. Also, we can add the pieces of test code into a test method in `FlussRecordAsPaimonRowTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Lake][Paimon] Fix npe with FlussRecordAsPaimonRow [fluss]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia merged PR #2765:
URL: https://github.com/apache/fluss/pull/2765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Lake][Paimon] Fix npe with FlussRecordAsPaimonRow [fluss]
Posted by "ThorneANN (via GitHub)" <gi...@apache.org>.
ThorneANN commented on PR #2765:
URL: https://github.com/apache/fluss/pull/2765#issuecomment-3990054085
> > @ThorneANN Thanks. LGTM!
>
> @ThorneANN One minor comments: Could you please add a simple test in `FlussRecordAsPaimonRowTest` instead of introduing a new test class. Also, we can add the pieces of test code into a test method in `FlussRecordAsPaimonRowTest`.
> > @ThorneANN Thanks. LGTM!
>
> @ThorneANN One minor comments: Could you please add a simple test in `FlussRecordAsPaimonRowTest` instead of introduing a new test class. Also, we can add the pieces of test code into a test method in `FlussRecordAsPaimonRowTest`.
Good idea, and i have done this work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Lake][Paimon] Fix npe with FlussRecordAsPaimonRow [fluss]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on PR #2765:
URL: https://github.com/apache/fluss/pull/2765#issuecomment-3994895115
I append a small commit to comact the testing. Will merge after ci pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Lake][Paimon] Fix npe with FlussRecordAsPaimonRow [fluss]
Posted by "ThorneANN (via GitHub)" <gi...@apache.org>.
ThorneANN commented on PR #2765:
URL: https://github.com/apache/fluss/pull/2765#issuecomment-3988966710
@luoyuxia help retrigger ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Lake][Paimon] fix npe with FlussRecordAsPaimonRow [fluss]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2765:
URL: https://github.com/apache/fluss/pull/2765#discussion_r2872407475
##########
fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/FlussRecordAsPaimonRow.java:
##########
@@ -49,6 +51,7 @@ public FlussRecordAsPaimonRow(int bucket, RowType tableTowType) {
}
public void setFlussRecord(LogRecord logRecord) {
+ checkNotNull(logRecord, "logRecord must not be null");
Review Comment:
Minor consistency: the new checkNotNull message doesn't end with a period, while the other (new) precondition messages in this class do. Consider making this message consistent (e.g., punctuation) to keep error output uniform.
```suggestion
checkNotNull(logRecord, "logRecord must not be null.");
```
##########
fluss-lake/fluss-lake-paimon/src/main/java/org/apache/fluss/lake/paimon/tiering/FlussRecordAsPaimonRow.java:
##########
@@ -74,11 +77,13 @@ public int getFieldCount() {
@Override
public RowKind getRowKind() {
+ checkState(logRecord != null, "setFlussRecord() must be called before accessing the row.");
return toRowKind(logRecord.getChangeType());
Review Comment:
The new defensive preconditions (e.g., this checkState) change the failure mode from an opaque NPE to an IllegalStateException. There are existing unit tests for this class, but none currently assert the uninitialized-access behavior (calling accessors before setFlussRecord()) or setFlussRecord(null). Please add tests to lock in the exception type + message for these cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Lake][Paimon] Fix npe with FlussRecordAsPaimonRow [fluss]
Posted by "ThorneANN (via GitHub)" <gi...@apache.org>.
ThorneANN commented on PR #2765:
URL: https://github.com/apache/fluss/pull/2765#issuecomment-3994951841
the ci fail because of the fluss-lake-iceberg test failed ,may be i can fix it with another pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org