You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/22 06:32:58 UTC
[jira] [Commented] (THRIFT-4012) Python Twisted implementation uses
implements, not compatible with Py3
[ https://issues.apache.org/jira/browse/THRIFT-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769242#comment-15769242 ]
ASF GitHub Bot commented on THRIFT-4012:
----------------------------------------
GitHub user DaGenix opened a pull request:
https://github.com/apache/thrift/pull/1144
THRIFT-4012: Zope implements doesn't work with Python 3; @implementer does
Replace uses of implements with @implementer since the former does not
work with Python 3, while the latter works with both Python 2 and 3.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaGenix/thrift fix-py3-twisted
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1144
----
commit 6821d756344494bb00a0a1fd67871ff722c0990a
Author: Palmer Cox <pa...@fiscalnote.com>
Date: 2016-12-22T06:24:33Z
Zope implements doesn't work with Python 3; @implementer does
Replace uses of implements with @implementer since the former does not
work with Python 3, while the latter works with both Python 2 and 3.
----
> Python Twisted implementation uses implements, not compatible with Py3
> ----------------------------------------------------------------------
>
> Key: THRIFT-4012
> URL: https://issues.apache.org/jira/browse/THRIFT-4012
> Project: Thrift
> Issue Type: Bug
> Reporter: Palmer
>
> The Zope implements method is not compatible with Python 3. Instead, @implementer is compatible with Python 3 as well as Python 2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)