[jira] [Commented] (SSHD-340) Hanging threads left working when server is shut down

["jpalacios (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SSHD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636291#comment-16636291 ] 

jpalacios commented on SSHD-340:
--------------------------------

Hi [~gnt] / [~lgoldstein],
I was wondering if I could get some context into this change. For Bitbucket Server this was an API breaking change because whenever an admin changes the server port we would stop the server and start it on the new port number. It's not a big effort to create a new server but I'm worried about these types of changes in a minor release and I'm whether we should expect to find more changes like this in this release and/or future ones.

Cheers
Juan

> Hanging threads left working when server is shut down
> -----------------------------------------------------
>
>                 Key: SSHD-340
>                 URL: https://issues.apache.org/jira/browse/SSHD-340
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 0.12.0
>            Reporter: Sampo Savolainen
>            Priority: Major
>             Fix For: 2.0.1
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> SSHD fails to stop properly due to errant threads. I've attached a thread dump from a point of execution where everything should have been cleaned up. The hanging threads happen only if the server has accepted connections and they do not hang forever, they seem to stop themselves after a minute or so. This might be an executor pool which is not shut down correctly.
> Earlier versions (0.8.0 and 0.9.0) did not exhibit this behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)